Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1917)

Unified Diff: components/ownership/owner_settings_service.h

Issue 654263003: Implemented OwnerSettingsService::Set() method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ownership/owner_settings_service.h
diff --git a/components/ownership/owner_settings_service.h b/components/ownership/owner_settings_service.h
index ed4a1b5be90a696b00c90f66522dde1f92d3b45a..20a62f8efbc1236310416be623eaf81ca3eb24c2 100644
--- a/components/ownership/owner_settings_service.h
+++ b/components/ownership/owner_settings_service.h
@@ -20,6 +20,7 @@
namespace base {
class TaskRunner;
+class Value;
}
namespace ownership {
@@ -31,7 +32,8 @@ class PublicKey;
// which deal with ownership, keypairs and owner-related settings.
class OWNERSHIP_EXPORT OwnerSettingsService : public KeyedService {
public:
- typedef base::Callback<void(std::string policy_blob)>
+ typedef base::Callback<void(
+ scoped_ptr<enterprise_management::PolicyFetchResponse> policy_response)>
AssembleAndSignPolicyAsyncCallback;
typedef base::Callback<void(bool is_owner)> IsOwnerCallback;
@@ -60,12 +62,16 @@ class OWNERSHIP_EXPORT OwnerSettingsService : public KeyedService {
scoped_ptr<enterprise_management::PolicyData> policy,
const AssembleAndSignPolicyAsyncCallback& callback);
- // Signs |settings| with the private half of the owner key and sends
- // the resulting policy blob for storage. The
- // result of the operation is reported through |callback|.
- virtual void SignAndStorePolicyAsync(
- scoped_ptr<enterprise_management::PolicyData> policy,
- const base::Closure& callback) = 0;
+ // Checks whether |setting| is handled by OwnerSettingsService.
+ virtual bool HandlesSetting(const std::string& setting) = 0;
+
+ // Sets |setting| value to |value|.
+ virtual void Set(const std::string& setting, const base::Value& value) = 0;
+
+ void SetBoolean(const std::string& setting, bool value);
+ void SetInteger(const std::string& setting, int value);
+ void SetDouble(const std::string& setting, double value);
+ void SetString(const std::string& setting, const std::string& value);
protected:
void ReloadKeypair();

Powered by Google App Engine
This is Rietveld 408576698