Source/core/loader/ImageLoader.h - Issue 654253003: Error event shouldn't fire when image is updated on environment changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/loader/ImageLoader.h

Issue 654253003: Error event shouldn't fire when image is updated on environment changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/frame/FrameView.cpp ('K') | « Source/core/frame/FrameView.cpp ('k') | Source/core/loader/ImageLoader.cpp » ('j') | Source/core/loader/ImageLoader.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2004, 2009 Apple Inc. All rights reserved.	4 * Copyright (C) 2004, 2009 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 168 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
179 #endif	179 #endif

180 Timer<ImageLoader> m_derefElementTimer;	180 Timer<ImageLoader> m_derefElementTimer;

181 AtomicString m_failedLoadURL;	181 AtomicString m_failedLoadURL;

182 WeakPtr<Task> m_pendingTask; // owned by Microtask	182 WeakPtr<Task> m_pendingTask; // owned by Microtask

183 OwnPtr<IncrementLoadEventDelayCount> m_loadDelayCounter;	183 OwnPtr<IncrementLoadEventDelayCount> m_loadDelayCounter;

184 bool m_hasPendingLoadEvent : 1;	184 bool m_hasPendingLoadEvent : 1;

185 bool m_hasPendingErrorEvent : 1;	185 bool m_hasPendingErrorEvent : 1;

186 bool m_imageComplete : 1;	186 bool m_imageComplete : 1;

187 bool m_loadingImageDocument : 1;	187 bool m_loadingImageDocument : 1;

188 bool m_elementIsProtected : 1;	188 bool m_elementIsProtected : 1;

	189 bool m_environmentChangeOnly : 1;
	Mike West 2014/10/17 14:12:40 How about 'shouldSuppressOnErrorEvents' or somethi How about 'shouldSuppressOnErrorEvents' or something like that?
189 unsigned m_highPriorityClientCount;	190 unsigned m_highPriorityClientCount;

190 };	191 };

191	192

192 }	193 }

193	194

194 #endif	195 #endif

OLD	NEW