Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chrome/browser/profiles/profile_manager.h

Issue 654223009: Standardize usage of virtual/override/final in chrome/browser/profiles/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_manager.h
diff --git a/chrome/browser/profiles/profile_manager.h b/chrome/browser/profiles/profile_manager.h
index efad19a690fd3cc3ffc53fa4a37274290ee169b6..d246aaddf610d624048f2b8d8110e52b9a9bb966 100644
--- a/chrome/browser/profiles/profile_manager.h
+++ b/chrome/browser/profiles/profile_manager.h
@@ -34,7 +34,7 @@ class ProfileManager : public base::NonThreadSafe,
typedef base::Callback<void(Profile*, Profile::CreateStatus)> CreateCallback;
explicit ProfileManager(const base::FilePath& user_data_dir);
- virtual ~ProfileManager();
+ ~ProfileManager() override;
#if defined(ENABLE_SESSION_SERVICE)
// Invokes SessionServiceFactory::ShutdownForProfile() for all profiles.
@@ -188,14 +188,14 @@ class ProfileManager : public base::NonThreadSafe,
bool IsLoggedIn() const { return logged_in_; }
// content::NotificationObserver implementation.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// Profile::Delegate implementation:
- virtual void OnProfileCreated(Profile* profile,
- bool success,
- bool is_new_profile) override;
+ void OnProfileCreated(Profile* profile,
+ bool success,
+ bool is_new_profile) override;
protected:
// Does final initial actions.
@@ -287,12 +287,12 @@ class ProfileManager : public base::NonThreadSafe,
class BrowserListObserver : public chrome::BrowserListObserver {
public:
explicit BrowserListObserver(ProfileManager* manager);
- virtual ~BrowserListObserver();
+ ~BrowserListObserver() override;
// chrome::BrowserListObserver implementation.
- virtual void OnBrowserAdded(Browser* browser) override;
- virtual void OnBrowserRemoved(Browser* browser) override;
- virtual void OnBrowserSetLastActive(Browser* browser) override;
+ void OnBrowserAdded(Browser* browser) override;
+ void OnBrowserRemoved(Browser* browser) override;
+ void OnBrowserSetLastActive(Browser* browser) override;
private:
ProfileManager* profile_manager_;
@@ -359,8 +359,8 @@ class ProfileManagerWithoutInit : public ProfileManager {
explicit ProfileManagerWithoutInit(const base::FilePath& user_data_dir);
protected:
- virtual void DoFinalInitForServices(Profile*, bool) override {}
- virtual void DoFinalInitLogging(Profile*) override {}
+ void DoFinalInitForServices(Profile*, bool) override {}
+ void DoFinalInitLogging(Profile*) override {}
};
#endif // CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_

Powered by Google App Engine
This is Rietveld 408576698