Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2212)

Unified Diff: chrome/browser/profiles/profile_downloader.h

Issue 654223009: Standardize usage of virtual/override/final in chrome/browser/profiles/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_downloader.h
diff --git a/chrome/browser/profiles/profile_downloader.h b/chrome/browser/profiles/profile_downloader.h
index 3a6293837075650642d981a6d61c8df4f744ab6a..aac6bb24e630eb29de305e98c1e94cc6e749e7ef 100644
--- a/chrome/browser/profiles/profile_downloader.h
+++ b/chrome/browser/profiles/profile_downloader.h
@@ -41,7 +41,7 @@ class ProfileDownloader : public gaia::GaiaOAuthClient::Delegate,
};
explicit ProfileDownloader(ProfileDownloaderDelegate* delegate);
- virtual ~ProfileDownloader();
+ ~ProfileDownloader() override;
// Starts downloading profile information if the necessary authorization token
// is ready. If not, subscribes to token service and starts fetching if the
@@ -86,28 +86,28 @@ class ProfileDownloader : public gaia::GaiaOAuthClient::Delegate,
FRIEND_TEST_ALL_PREFIXES(ProfileDownloaderTest, DefaultURL);
// gaia::GaiaOAuthClient::Delegate implementation.
- virtual void OnGetUserInfoResponse(
+ void OnGetUserInfoResponse(
scoped_ptr<base::DictionaryValue> user_info) override;
- virtual void OnOAuthError() override;
- virtual void OnNetworkError(int response_code) override;
+ void OnOAuthError() override;
+ void OnNetworkError(int response_code) override;
// Overriden from net::URLFetcherDelegate:
- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;
+ void OnURLFetchComplete(const net::URLFetcher* source) override;
// Overriden from ImageDecoder::Delegate:
- virtual void OnImageDecoded(const ImageDecoder* decoder,
- const SkBitmap& decoded_image) override;
- virtual void OnDecodeImageFailed(const ImageDecoder* decoder) override;
+ void OnImageDecoded(const ImageDecoder* decoder,
+ const SkBitmap& decoded_image) override;
+ void OnDecodeImageFailed(const ImageDecoder* decoder) override;
// Overriden from OAuth2TokenService::Observer:
- virtual void OnRefreshTokenAvailable(const std::string& account_id) override;
+ void OnRefreshTokenAvailable(const std::string& account_id) override;
// Overriden from OAuth2TokenService::Consumer:
- virtual void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
- const std::string& access_token,
- const base::Time& expiration_time) override;
- virtual void OnGetTokenFailure(const OAuth2TokenService::Request* request,
- const GoogleServiceAuthError& error) override;
+ void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
+ const std::string& access_token,
+ const base::Time& expiration_time) override;
+ void OnGetTokenFailure(const OAuth2TokenService::Request* request,
+ const GoogleServiceAuthError& error) override;
// Parses the entry response and gets the name, profile image URL and locale.
// |data| should be the JSON formatted data return by the response.

Powered by Google App Engine
This is Rietveld 408576698