Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_android.cc

Issue 654223006: Cleanup GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gpu_memory_buffer_impl_android.cc
diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_android.cc b/content/common/gpu/client/gpu_memory_buffer_impl_android.cc
index a85654226ab1ba8908231bc9eb5d5b827faf1d84..482b4b97eac8ef671c47564f1154ab0254a54990 100644
--- a/content/common/gpu/client/gpu_memory_buffer_impl_android.cc
+++ b/content/common/gpu/client/gpu_memory_buffer_impl_android.cc
@@ -60,7 +60,24 @@ void GpuMemoryBufferImpl::AllocateForChildProcess(
void GpuMemoryBufferImpl::DeletedByChildProcess(
gfx::GpuMemoryBufferType type,
const gfx::GpuMemoryBufferId& id,
- base::ProcessHandle child_process) {
+ base::ProcessHandle child_process,
+ int child_client_id,
+ uint32 sync_point) {
+ switch (type) {
+ case gfx::SHARED_MEMORY_BUFFER:
+ break;
+ case gfx::SURFACE_TEXTURE_BUFFER:
+ if (id.secondary_id != child_client_id) {
+ LOG(ERROR)
+ << "Child attempting to delete GpuMemoryBuffer it does not own";
+ } else {
+ GpuMemoryBufferImplSurfaceTexture::DeletedByChildProcess(id,
+ sync_point);
+ }
+ break;
+ default:
+ LOG(ERROR) << "Unexpected GpuMemoryBufferType";
+ }
}
// static

Powered by Google App Engine
This is Rietveld 408576698