Cleanup GpuMemoryBuffer

content/common/gpu/client/gpu_channel_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_channel_host.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
@@ skipping 263 matching lines @@
 
   return base::FileDescriptor(duped_handle, true);
 #endif
 }
 
 int32 GpuChannelHost::ReserveTransferBufferId() {
   return next_transfer_buffer_id_.GetNext();
 }
 
 gfx::GpuMemoryBufferHandle GpuChannelHost::ShareGpuMemoryBufferToGpuProcess(
-    gfx::GpuMemoryBufferHandle source_handle) {
+    gfx::GpuMemoryBufferHandle source_handle,
+    bool* requires_sync_point) {
+  DCHECK(requires_sync_point);

[reveman, 2014/11/03 22:26:12]

nit: I think this DCHECK is overkill

   switch (source_handle.type) {
     case gfx::SHARED_MEMORY_BUFFER: {
       gfx::GpuMemoryBufferHandle handle;
       handle.type = gfx::SHARED_MEMORY_BUFFER;
       handle.handle = ShareToGpuProcess(source_handle.handle);
+      *requires_sync_point = false;
       return handle;
     }
 #if defined(USE_OZONE)
     case gfx::OZONE_NATIVE_BUFFER:
+      *requires_sync_point = true;
       return source_handle;
 #endif
 #if defined(OS_MACOSX)
     case gfx::IO_SURFACE_BUFFER:
+      *requires_sync_point = true;
       return source_handle;
 #endif
 #if defined(OS_ANDROID)
     case gfx::SURFACE_TEXTURE_BUFFER:
+      *requires_sync_point = true;
       return source_handle;
 #endif
 #if defined(USE_X11)
     case gfx::X11_PIXMAP_BUFFER:
+      *requires_sync_point = true;
       return source_handle;
 #endif
     default:
       NOTREACHED();
+      *requires_sync_point = false;

[reveman, 2014/11/03 22:26:12]

nit: I don't think you should set requires_sync_point in the error case

       return gfx::GpuMemoryBufferHandle();
   }
 }
 
 int32 GpuChannelHost::ReserveImageId() {
   return next_image_id_.GetNext();
 }
 
 int32 GpuChannelHost::GenerateRouteID() {
   return next_route_id_.GetNext();
@@ skipping 71 matching lines @@
 
   listeners_.clear();
 }
 
 bool GpuChannelHost::MessageFilter::IsLost() const {
   AutoLock lock(lock_);
   return lost_;
 }
 
 }  // namespace content