Cleanup GpuMemoryBuffer

content/common/gpu/client/gpu_memory_buffer_impl_mac.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl.h"
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h"
 #include "content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h"
 
 namespace content {
@@ skipping 60 matching lines @@
       return GpuMemoryBufferImplSharedMemory::CreateFromHandle(
           handle, size, format, callback);
     case gfx::IO_SURFACE_BUFFER:
       return GpuMemoryBufferImplIOSurface::CreateFromHandle(
           handle, size, format, callback);
     default:
       return scoped_ptr<GpuMemoryBufferImpl>();
   }
 }
 
+// static
+bool GpuMemoryBufferImpl::NeedsDestructionSyncPoint(
+    gfx::GpuMemoryBufferType type) {
+  return false;

[piman, 2014/10/31 01:24:18]

true for IO_SURFACE_BUFFER?

Do we really need a per-platform implementation of this? What really matter is
what we do relative to the handle type (whether it's an OS handle that we dup,
or it's a reference to a key in the GPU process), and that doesn't vary per
platform, so a single implementation with a single switch statement seems the
most reasonable.

IO_SURFACE_BUFFER, X11_PIXMAP_BUFFER, OZONE_NATIVE_BUFFER,
SURFACE_TEXTURE_BUFFER need a sync point.
SHARED_MEMORY_BUFFER doesn't.

+}
+
 }  // namespace content