Basic implementation of incremental marking.

src/heap-inl.h

 // Copyright 2006-2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 265 matching lines @@
 }
 
 
 void Heap::RecordWrite(Address address, int offset) {
   if (!InNewSpace(address)) StoreBuffer::Mark(address + offset);
 }
 
 
 void Heap::RecordWrites(Address address, int start, int len) {
   if (!InNewSpace(address)) {
-    for (int i = 0; i < len; i += kPointerSize) {
-      StoreBuffer::Mark(address + start + i);
+    for (int i = 0; i < len; i++) {

[Erik Corry, 2011/02/22 12:27:19]

I'm an idiot!

+      StoreBuffer::Mark(address + start + i*kPointerSize);

[Erik Corry, 2011/02/22 12:27:19]

Spaces around *

     }
   }
 }
 
 
 OldSpace* Heap::TargetSpace(HeapObject* object) {
   InstanceType type = object->map()->instance_type();
   AllocationSpace space = TargetSpaceId(type);
   return (space == OLD_POINTER_SPACE)
       ? old_pointer_space_
@@ skipping 273 matching lines @@
 
 
 void ExternalStringTable::ShrinkNewStrings(int position) {
   new_space_strings_.Rewind(position);
   Verify();
 }
 
 } }  // namespace v8::internal
 
 #endif  // V8_HEAP_INL_H_