Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 654203007: cc: Delete non-impl-side-painting animation freezing logic (Closed)

Created:
6 years, 2 months ago by ajuma
Modified:
6 years, 2 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, cc-bugs_chromium.org, mithro-old
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Delete non-impl-side-painting animation freezing logic This deletes code that froze the animation clock when we skipped frames because of checkerboarding. This logic was only enabled for non-impl-side painting (to handle the case of animating very large layers, where failing to freeze the clock would cause rasterization to constantly lag behind, resulting in checkerboarding whenever a draw was forced). Since all shipping renderers use impl-side painting now, this logic is no longer needed. BUG=None Committed: https://crrev.com/0a960c01bf73c71b12db070b45612e24ab9d9931 Cr-Commit-Position: refs/heads/master@{#300277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -98 lines) Patch
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/thread_proxy.cc View 6 chunks +2 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ajuma
6 years, 2 months ago (2014-10-20 15:43:00 UTC) #2
Ian Vollick
On 2014/10/20 at 15:43:00, ajuma wrote: > lgtm!
6 years, 2 months ago (2014-10-20 15:59:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654203007/1
6 years, 2 months ago (2014-10-20 16:01:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 16:38:31 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 16:39:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a960c01bf73c71b12db070b45612e24ab9d9931
Cr-Commit-Position: refs/heads/master@{#300277}

Powered by Google App Engine
This is Rietveld 408576698