Skip initial seek to 0 on fling

media/base/android/media_player_bridge.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_player_bridge.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 20 matching lines @@
     MediaPlayerManager* manager,
     const RequestMediaResourcesCB& request_media_resources_cb,
     const GURL& frame_url,
     bool allow_credentials)
     : MediaPlayerAndroid(player_id,
                          manager,
                          request_media_resources_cb,
                          frame_url),
       prepared_(false),
       pending_play_(false),
+      should_seek_on_prepare_(false),
       url_(url),
       first_party_for_cookies_(first_party_for_cookies),
       user_agent_(user_agent),
       hide_url_log_(hide_url_log),
       width_(0),
       height_(0),
       can_pause_(true),
       can_seek_forward_(true),
       can_seek_backward_(true),
       volume_(-1.0),
@@ skipping 280 matching lines @@
   if (!prepared_)
     return height_;
   JNIEnv* env = base::android::AttachCurrentThread();
   return Java_MediaPlayerBridge_getVideoHeight(
       env, j_media_player_bridge_.obj());
 }
 
 void MediaPlayerBridge::SeekTo(base::TimeDelta timestamp) {
   // Record the time to seek when OnMediaPrepared() is called.
   pending_seek_ = timestamp;
+  should_seek_on_prepare_ = true;
 
   if (j_media_player_bridge_.is_null())
     Prepare();
   else if (prepared_)
     SeekInternal(timestamp);
 }
 
 base::TimeDelta MediaPlayerBridge::GetCurrentTime() {
   if (!prepared_)
     return pending_seek_;
@@ skipping 11 matching lines @@
       Java_MediaPlayerBridge_getDuration(env, j_media_player_bridge_.obj());
   return duration_ms < 0 ? media::kInfiniteDuration()
                          : base::TimeDelta::FromMilliseconds(duration_ms);
 }
 
 void MediaPlayerBridge::Release() {
   if (j_media_player_bridge_.is_null())
     return;
 
   time_update_timer_.Stop();
-  if (prepared_)
+  if (prepared_) {
     pending_seek_ = GetCurrentTime();
+    should_seek_on_prepare_ = true;
+  }
+
   prepared_ = false;
   pending_play_ = false;
   SetVideoSurface(gfx::ScopedJavaSurface());
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_MediaPlayerBridge_release(env, j_media_player_bridge_.obj());
   j_media_player_bridge_.Reset();
   DetachListener();
 }
 
 void MediaPlayerBridge::SetVolume(double volume) {
@@ skipping 26 matching lines @@
 
 void MediaPlayerBridge::OnMediaPrepared() {
   if (j_media_player_bridge_.is_null())
     return;
 
   prepared_ = true;
   duration_ = GetDuration();
 
   // If media player was recovered from a saved state, consume all the pending
   // events.
-  PendingSeekInternal(pending_seek_);
+  // if (pending_seek_.InMilliseconds() >= 0) {

[qinmin, 2014/10/20 17:16:19]

cannot we just change this line to > 0 and it will have the same effect?

When mediaplayer becomes prepared, the position is always 0. So if we don't do
any seek when pending_seek_ is not changed, it will have the same effect.

[whywhat, 2014/10/20 18:41:35]

Some websites actually do call video.seekTo(0) before calling video.play() so we
should distinguish the actual seek to 0 from the default value.

[qinmin, 2014/10/20 21:44:52]

remove this comments, it is not helpful for understanding the logic

On 2014/10/20 18:41:35, whywhat wrote:

[dgn, 2014/10/21 10:07:18]

Done.

+  if (should_seek_on_prepare_) {
+    PendingSeekInternal(pending_seek_);

[whywhat, 2014/10/20 18:41:35]

should we reset pending_seek_ to 0 and should_seek_on_prepare_ to false here?

[dgn, 2014/10/21 10:07:18]

Done.

+  }

[whywhat, 2014/10/20 18:41:35]

nit: no need for curly braces here

[dgn, 2014/10/21 10:07:17]

They are needed now.

 
   if (pending_play_) {
     StartInternal();
     pending_play_ = false;
   }
 
   UpdateAllowedOperations();
   manager()->OnMediaMetadataChanged(
       player_id(), duration_, width_, height_, true);
 }
@@ skipping 87 matching lines @@
 
 GURL MediaPlayerBridge::GetUrl() {
   return url_;
 }
 
 GURL MediaPlayerBridge::GetFirstPartyForCookies() {
   return first_party_for_cookies_;
 }
 
 }  // namespace media