Issue 6542027: Out of line cleanups for Mac.

Issue 6542027: Out of line cleanups for Mac. (Closed)

Created:
9 years, 10 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Out of line cleanups for Mac. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75626

Patch Set 1 #

Patch Set 2 : mac compile fix #

Patch Set 3 : mac compile fix #

Total comments: 2

Patch Set 4 : Killer rebase. :( #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -76 lines)			Patch
M	app/surface/accelerated_surface_mac.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/surface/accelerated_surface_mac.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/mach_broker_mac.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/mach_broker_mac.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac.h	View		1 chunk	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h	View		2 chunks	+8 lines, -34 lines	0 comments	Download
A	chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm	View	1	1 chunk	+64 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/constrained_window_mac.h	View	1 2 3	3 chunks	+10 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/cocoa/constrained_window_mac.mm	View	1 2 3	2 chunks	+43 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/rwhvm_editcommand_helper.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/rwhvm_editcommand_helper.mm	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/table_row_nsimage_cache.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/table_row_nsimage_cache.mm	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 10 months ago (2011-02-18 23:35:11 UTC) #2

lg

http://codereview.chromium.org/6542027/diff/3001/chrome/browser/renderer_host...
File chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
(right):

http://codereview.chromium.org/6542027/diff/3001/chrome/browser/renderer_host...
chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc:19:
~AcceleratedSurfaceContainerManagerMac() {}
indent 4?

http://codereview.chromium.org/6542027/diff/3001/chrome/browser/ui/cocoa/cons...
File chrome/browser/ui/cocoa/constrained_window_mac.h (right):

http://codereview.chromium.org/6542027/diff/3001/chrome/browser/ui/cocoa/cons...
chrome/browser/ui/cocoa/constrained_window_mac.h:28: virtual
~ConstrainedWindowMacDelegate() {}
:-P

Remove the space between {} in the line above when you're here

Expand Messages | Collapse Messages