Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 654193002: Preparation of Promise<T> support in the Web IDL parser (Closed)

Created:
6 years, 2 months ago by yhirano
Modified:
6 years, 2 months ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Preparation of Promise<T> support in the Web IDL parser We are about to support Promise<T> syntax in the Web IDL parser. As it is specified in the Web IDL spec, I would like to implement it in tools/idl_parser. This CL is a preparation for the change in chromium side, in order not to break the existing behavior when the change lands. BUG=421539 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/bindings/scripts/idl_definitions.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yhirano
PTAL This is a preperation for https://codereview.chromium.org/653343002/ .
6 years, 2 months ago (2014-10-15 07:04:42 UTC) #2
Jens Widell
LGTM
6 years, 2 months ago (2014-10-15 07:09:08 UTC) #3
haraken
LGTM
6 years, 2 months ago (2014-10-15 07:37:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654193002/1
6 years, 2 months ago (2014-10-16 23:44:22 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 01:49:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183849

Powered by Google App Engine
This is Rietveld 408576698