chrome/browser/chromeos/login/user_flow.h - Issue 654173005: Don't allow restarting to apply custom flags when supervised user creation flow is active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/user_flow.h

Issue 654173005: Don't allow restarting to apply custom flags when supervised user creation flow is active (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: logging restart due flags as warning, don't restart for supervised users Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/supervised/supervised_user_login_flow.cc ('k') | chrome/browser/chromeos/login/user_flow.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/user_flow.h

diff --git a/chrome/browser/chromeos/login/user_flow.h b/chrome/browser/chromeos/login/user_flow.h

index 04552294dfff3f2741f69a4571653940c5bd463f..ef7955f14c9a08f0f2dae04f25f70a86d74e2859 100644

--- a/chrome/browser/chromeos/login/user_flow.h

+++ b/chrome/browser/chromeos/login/user_flow.h

@@ -26,6 +26,7 @@ class UserFlow {

virtual bool ShouldShowSettings() = 0;

virtual bool ShouldLaunchBrowser() = 0;

virtual bool ShouldSkipPostLoginScreens() = 0;

+ virtual bool SupportsEarlyRestartToApplyFlags() = 0;

virtual bool HandleLoginFailure(const AuthFailure& failure) = 0;

virtual void HandleLoginSuccess(const UserContext& context) = 0;

virtual bool HandlePasswordChangeDetected() = 0;

@@ -54,6 +55,7 @@ class DefaultUserFlow : public UserFlow {

virtual bool ShouldShowSettings() override;

virtual bool ShouldLaunchBrowser() override;

virtual bool ShouldSkipPostLoginScreens() override;

+ virtual bool SupportsEarlyRestartToApplyFlags() override;

virtual bool HandleLoginFailure(const AuthFailure& failure) override;

virtual void HandleLoginSuccess(const UserContext& context) override;

virtual bool HandlePasswordChangeDetected() override;