Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 654123004: Revert of Sets the default background color of inline signin and user manager to grey (Closed)

Created:
6 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, hendrikw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Sets the default background color of inline signin and user manager to grey (patchset #8 id:450001 of https://codereview.chromium.org/637083002/) Reason for revert: Broke content_unittests on Blink waterfall. See https://code.google.com/p/chromium/issues/detail?id=368225#c5 . Original issue's description: > Sets the default background color of inline signin and user manager to grey > > The purpose is to avoid the white flash before the web content is loaded. > > This CL only handles the view implementation, mac implementation will be handled in the next cl. > > BUG=368225 > > Committed: https://crrev.com/fe517ffc1a9550ff4557b5718b01b103bd134616 > Cr-Commit-Position: refs/heads/master@{#299594} TBR=rogerta@chromium.org,noms@chromium.org,sky@chromium.org,asvitkine@chromium.org,ccameron@google.com,sievers@chromium.org,ccameron@chromium.org,benwells@chromium.org,fsamuel@chromium.org,nasko@chromium.org,guohui@chromium.org NOTREECHECKS=true NOTRY=true BUG=368225 Committed: https://crrev.com/e4c95aeb6a7360f2e915efd20cc6d9c021a23ab9 Cr-Commit-Position: refs/heads/master@{#299624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -110 lines) Patch
M chrome/browser/chromeos/first_run/first_run_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_avatar_icon_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_avatar_icon_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/user_manager_mac.mm View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/profiles/user_manager_view.cc View 3 chunks +1 line, -9 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +6 lines, -12 lines 0 comments Download
M content/public/browser/render_widget_host_view.h View 2 chunks +3 lines, -7 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 2 chunks +3 lines, -18 lines 0 comments Download
M extensions/components/native_app_window/native_app_window_views.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of Sets the default background color of inline signin and user manager to ...
6 years, 2 months ago (2014-10-15 01:51:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654123004/1
6 years, 2 months ago (2014-10-15 01:52:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 01:53:48 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 01:55:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4c95aeb6a7360f2e915efd20cc6d9c021a23ab9
Cr-Commit-Position: refs/heads/master@{#299624}

Powered by Google App Engine
This is Rietveld 408576698