ChannelMojo: Fail when GetFileHandleForProcess() failed.

ipc/mojo/ipc_mojo_bootstrap.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/mojo/ipc_mojo_bootstrap.h"
 
 #include "base/logging.h"
 #include "base/process/process_handle.h"
 #include "ipc/ipc_message_utils.h"
 #include "ipc/ipc_platform_file.h"
@@ skipping 38 matching lines @@
   mojo::embedder::PlatformChannelPair channel_pair;
   server_pipe_ = channel_pair.PassServerHandle();
   PlatformFileForTransit client_pipe = GetFileHandleForProcess(
 #if defined(OS_POSIX)
       channel_pair.PassClientHandle().release().fd,
 #else
       channel_pair.PassClientHandle().release().handle,
 #endif
       client_process_,
       true);
-  CHECK(client_pipe != IPC::InvalidPlatformFileForTransit());
+  if (client_pipe == IPC::InvalidPlatformFileForTransit()) {
+#if !defined(OS_WIN)
+    // GetFileHandleForProcess() only fails on Windows.
+    NOTREACHED();
+#endif
+    DLOG(WARNING) << "Failed to translate file handle for client process.";
+    Fail();
+    return;
+  }
+
   scoped_ptr<Message> message(new Message());
   ParamTraits<PlatformFileForTransit>::Write(message.get(), client_pipe);
   Send(message.release());
 
   set_state(STATE_WAITING_ACK);
 }
 
 void MojoServerBootstrap::SendClientPipeIfReady() {
   // Is the client launched?
   if (client_process_ == base::kNullProcessHandle)
@@ skipping 101 matching lines @@
 void MojoBootstrap::Init(scoped_ptr<Channel> channel, Delegate* delegate) {
   channel_ = channel.Pass();
   delegate_ = delegate;
 }
 
 bool MojoBootstrap::Connect() {
   return channel_->Connect();
 }
 
 void MojoBootstrap::OnBadMessageReceived(const Message& message) {
-  delegate_->OnBootstrapError();
+  Fail();
 }
 
 void MojoBootstrap::OnChannelError() {
-  if (state_ == STATE_READY)
+  if (state_ == STATE_READY || state_ == STATE_ERROR)
     return;
   DLOG(WARNING) << "Detected error on Mojo bootstrap channel.";
+  Fail();
+}
+
+void MojoBootstrap::Fail() {
+  set_state(STATE_ERROR);
   delegate()->OnBootstrapError();
 }
 
 bool MojoBootstrap::Send(Message* message) {
   return channel_->Send(message);
 }
 
 #if defined(OS_POSIX) && !defined(OS_NACL)
 int MojoBootstrap::GetClientFileDescriptor() const {
   return channel_->GetClientFileDescriptor();
 }
 
 int MojoBootstrap::TakeClientFileDescriptor() {
   return channel_->TakeClientFileDescriptor();
 }
 #endif  // defined(OS_POSIX) && !defined(OS_NACL)
 
 }  // namespace IPC