ChannelMojo: Fail when GetFileHandleForProcess() failed.

MojoChannel: Fail when GetFileHandleForProcess() failed.

On Windows, GetFileHandleForProcess() can fail. This CL
handles that case instead of just doing CHECK().

R=viettrungluu@chromium.org
BUG=419139
Committed: https://crrev.com/2580367532fe28da0456aadf70a2bfe5ca227d2d
Cr-Commit-Position: refs/heads/master@{#299731}

[Hajime Morrita, 2014-10-15 01:07:05]

Trung: PTAL? A ChannelMojo crash fix with a test.

[darin (slow to review), 2014-10-15 05:05:36]

darin@chromium.org changed reviewers:
+ darin@chromium.org

[darin (slow to review), 2014-10-15 05:05:37]

https://codereview.chromium.org/654113002/diff/20001/ipc/mojo/ipc_mojo_bootst...
File ipc/mojo/ipc_mojo_bootstrap.cc (right):

https://codereview.chromium.org/654113002/diff/20001/ipc/mojo/ipc_mojo_bootst...
ipc/mojo/ipc_mojo_bootstrap.cc:202: set_state(STATE_ERROR);
nit: is it possible for |this| to be destroyed during the call to
OnBootstrapError? Maybe you should call set_state(STATE_ERROR) first just in
case?

[Hajime Morrita, 2014-10-15 17:25:28]

Thanks for the review!

On 2014/10/15 05:05:37, darin wrote:
>
https://codereview.chromium.org/654113002/diff/20001/ipc/mojo/ipc_mojo_bootst...
> File ipc/mojo/ipc_mojo_bootstrap.cc (right):
> 
>
https://codereview.chromium.org/654113002/diff/20001/ipc/mojo/ipc_mojo_bootst...
> ipc/mojo/ipc_mojo_bootstrap.cc:202: set_state(STATE_ERROR);
> nit: is it possible for |this| to be destroyed during the call to
> OnBootstrapError? Maybe you should call set_state(STATE_ERROR) first just in
> case?
That's right. Done. PTAL?

[darin (slow to review), 2014-10-15 17:29:17]

LGTM

[Hajime Morrita, 2014-10-15 17:30:40]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-10-15 17:31:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/654113002/40001

[commit-bot: I haz the power, 2014-10-15 18:50:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-15 18:51:10]

Patchset 3 (id:??) landed as
https://crrev.com/2580367532fe28da0456aadf70a2bfe5ca227d2d
Cr-Commit-Position: refs/heads/master@{#299731}