Integrate gfx::Image into the ResourceBundle.

Integrate gfx::Image into the ResourceBundle.

This changes the definition of GetNativeImageNamed to return a gfx::Image and
adds GetImageNamed in addition. GetBitmapNamed now goes through that method. On
Linux, GetNativeImageNamed will load directly into a GdkPixbuf-backed Image. Mac
will still first load through Skia (a future CL will load directly into an
NSImage). All other platforms use Skia natively, so GetNativeImageNamed is the
same as GetImageNamed.

Mac was the only platform that used the old GetNativeImageNamed, so this also
transitions a bunch of Mac files by including ui/gfx/image.h.

This also obviates the need for platform-specific image caches in the
ResourceBundle, so there's some additional cleanup around that.

BUG=carnitas
TEST=All UI images in Chromium show up as before.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75605

[TVL, 2011-02-18 21:19:12]

http://codereview.chromium.org/6541031/diff/1/chrome/default_plugin/plugin_im...
File chrome/default_plugin/plugin_impl_mac.h (right):

http://codereview.chromium.org/6541031/diff/1/chrome/default_plugin/plugin_im...
chrome/default_plugin/plugin_impl_mac.h:288: // Plugin icon, weak (owned by
ResourceBundle).
this seems dangerous, why not just retain it so it doesn't break if resource
bundle starts caping it's cache size?

http://codereview.chromium.org/6541031/diff/1/ui/base/resource/resource_bundle.h
File ui/base/resource/resource_bundle.h (right):

http://codereview.chromium.org/6541031/diff/1/ui/base/resource/resource_bundl...
ui/base/resource/resource_bundle.h:112: // one image type to another.
ResourceBundle owns the result.
so this isn't completely true.  It might not go through a skia format, but if
the image was already loaded in skia format, then it does do the convert.

http://codereview.chromium.org/6541031/diff/1/ui/gfx/image.h
File ui/gfx/image.h (right):

http://codereview.chromium.org/6541031/diff/1/ui/gfx/image.h#newcode50
ui/gfx/image.h:50: // Does not retain |image|.
i'd tweak this, it's not that it does't retain, it assumes ownership because it
does release it.

[TVL, 2011-02-18 21:24:25]

Given the native and skia paths, I'm also worried about odd color transforms. 
Since what happens can depend on user actions, one run it might be skia ->
native, the next it might be native -> skia.  Depending on where the image is
used (renderer or straight in the ui), there is a good chance multiple or wrong
color corrects could happen on one of those loading sequences and not the other.
 So doing something to make the color conversions consistent seems important.

[Robert Sesek, 2011-02-18 21:48:17]

http://codereview.chromium.org/6541031/diff/1/chrome/default_plugin/plugin_im...
File chrome/default_plugin/plugin_impl_mac.h (right):

http://codereview.chromium.org/6541031/diff/1/chrome/default_plugin/plugin_im...
chrome/default_plugin/plugin_impl_mac.h:288: // Plugin icon, weak (owned by
ResourceBundle).
On 2011/02/18 21:19:12, TVL wrote:
> this seems dangerous, why not just retain it so it doesn't break if resource
> bundle starts caping it's cache size?

That's probably never going to happen. ResourceBundle claims ownership of all
pointers (except on Mac, until this point) it vends. This is just bringing this
code into alignment with how other platforms interact with ResourceBundle. I can
change it back if you feel strongly.

http://codereview.chromium.org/6541031/diff/1/ui/base/resource/resource_bundle.h
File ui/base/resource/resource_bundle.h (right):

http://codereview.chromium.org/6541031/diff/1/ui/base/resource/resource_bundl...
ui/base/resource/resource_bundle.h:112: // one image type to another.
ResourceBundle owns the result.
On 2011/02/18 21:19:12, TVL wrote:
> so this isn't completely true.  It might not go through a skia format, but if
> the image was already loaded in skia format, then it does do the convert.

Added a comment.

http://codereview.chromium.org/6541031/diff/1/ui/gfx/image.h
File ui/gfx/image.h (right):

http://codereview.chromium.org/6541031/diff/1/ui/gfx/image.h#newcode50
ui/gfx/image.h:50: // Does not retain |image|.
On 2011/02/18 21:19:12, TVL wrote:
> i'd tweak this, it's not that it does't retain, it assumes ownership because
it
> does release it.

Done.

[TVL, 2011-02-18 21:51:16]

lg