View API/implementation cleanup:...

ui/views/view_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/canvas.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 
 namespace ui {
 
 class ViewTest : public testing::Test {
  public:
   ViewTest() {}
   virtual ~ViewTest() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ViewTest);
 };
 
 TEST_F(ViewTest, SizeAndDisposition) {
   View v;
   EXPECT_TRUE(v.bounds().IsEmpty());
   EXPECT_TRUE(v.visible());
 
-  v.SetBoundsRect(gfx::Rect(10, 10, 200, 200));
+  v.SetBounds(gfx::Rect(10, 10, 200, 200));
   EXPECT_EQ(200, v.width());
 
   EXPECT_TRUE(v.GetPreferredSize().IsEmpty());
 }
 
 TEST_F(ViewTest, TreeOperations) {
   View v;
   EXPECT_EQ(NULL, v.GetWidget());
-  EXPECT_EQ(0, v.child_count());
+  EXPECT_TRUE(v.children_empty());
 
   View child1;
   v.AddChildView(&child1);
-  EXPECT_EQ(1, v.child_count());
+  EXPECT_EQ(1, v.children_size());
   EXPECT_EQ(&v, child1.parent());
 
   View child2;
   v.AddChildViewAt(&child2, 0);
-  EXPECT_EQ(2, v.child_count());
+  EXPECT_EQ(2, v.children_size());
   EXPECT_EQ(child1.parent(), child2.parent());
 
-  v.RemoveChildView(&child2);
-  EXPECT_EQ(1, v.child_count());
+  v.RemoveChildView(&child2, false);
+  EXPECT_EQ(1, v.children_size());
   EXPECT_EQ(NULL, child2.parent());
 
   //v.RemoveAllChildViews(false);
-  //EXPECT_EQ(0, v.child_count());
+  //EXPECT_TRUE(v.children_empty());
 }
 
 class ObserverView : public View {
  public:
   ObserverView()
       : view_added_(false),
         view_removed_(false),
         subject_view_(NULL) {}
   virtual ~ObserverView() {}
 
@@ skipping 87 matching lines @@
   ov.RemoveChildView(&v2);
   EXPECT_FALSE(ov.view_added());
   EXPECT_TRUE(ov.view_removed());
   EXPECT_EQ(&v2, ov.subject_view());
 
   EXPECT_FALSE(v3.in_widget());
   EXPECT_EQ(NULL, v3.GetWidget());
 }
 */
 
-TEST_F(ViewTest, Ids) {
-  const int kV1Id = 1;
-  const int kV2Id = 2;
-  const int kV3Id = 3;
-  const int kV4Id = 4;
-  const int kV5Id = 5;
-  const int kGroupId = 1;
+TEST_F(ViewTest, IDs) {
+  const int kV1ID = 1;
+  const int kV2ID = 2;
+  const int kV3ID = 3;
+  const int kV4ID = 4;
+  const int kV5ID = 5;
+  const int kGroupID = 1;
   View v1;
-  v1.set_id(kV1Id);
+  v1.set_id(kV1ID);
   View v2;
-  v2.set_id(kV2Id);
+  v2.set_id(kV2ID);
   View v3;
-  v3.set_id(kV3Id);
-  v3.set_group(kGroupId);
+  v3.set_id(kV3ID);
+  v3.set_group(kGroupID);
   View v4;
-  v4.set_id(kV4Id);
-  v4.set_group(kGroupId);
+  v4.set_id(kV4ID);
+  v4.set_group(kGroupID);
   v1.AddChildView(&v2);
   v2.AddChildView(&v3);
   v2.AddChildView(&v4);
 
-  EXPECT_EQ(&v4, v1.GetViewById(kV4Id));
-  EXPECT_EQ(&v1, v1.GetViewById(kV1Id));
-  EXPECT_EQ(NULL, v1.GetViewById(kV5Id)); // No V5 exists.
+  EXPECT_EQ(&v4, v1.GetViewByID(kV4ID));
+  EXPECT_EQ(&v1, v1.GetViewByID(kV1ID));
+  EXPECT_EQ(NULL, v1.GetViewByID(kV5ID)); // No V5 exists.
 
-  View::ViewVector vec;
-  v1.GetViewsWithGroup(kGroupId, &vec);
-  EXPECT_EQ(2, vec.size());
-  View::ViewVector::const_iterator it = find(vec.begin(), vec.end(), &v3);
-  EXPECT_NE(vec.end(), it);
-  it = find(vec.begin(), vec.end(), &v4);
-  EXPECT_NE(vec.end(), it);
+  View::Views views;
+  v1.GetViewsInGroup(kGroupID, &views);
+  EXPECT_EQ(2, views.size());
+  View::Views::const_iterator it = std::find(views.begin(), views.end(), &v3);
+  EXPECT_NE(views.end(), it);
+  it = std::find(views.begin(), views.end(), &v4);
+  EXPECT_NE(views.end(), it);
 }
 
 TEST_F(ViewTest, EventHandlers) {
 
 }
 
 TEST_F(ViewTest, Painting) {
 
 }
 
 }  // namespace ui