Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 654093003: Fix linker error due to missing MESSAGE_CENTER_EXPORT (Closed)

Created:
6 years, 2 months ago by binjin
Modified:
6 years, 2 months ago
CC:
chromium-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix linker error due to missing MESSAGE_CENTER_EXPORT Not sure in which condition this can be triggered, my environment is linux x64 with plain "component=shared_library clang=1", the actual linker invoked is "third_party/binutils/Linux_x64/Release/bin/ld.gold" Here is the error log from linker: /usr/lib64/gcc/x86_64-unknown-linux-gnu/4.9.1/../../../../include/c++/4.9.1/bits/stl_tree.h:1543: error: undefined reference to 'message_center::CompareTimestampSerial::operator()(message_center::Notification*, message_center::Notification*)' clang: error: linker command failed with exit code 1 (use -v to see invocation) BUG=None Committed: https://crrev.com/ac59b2cc31ddb0bf15074e6253fbf73196a39d69 Cr-Commit-Position: refs/heads/master@{#299933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/message_center/notification_list.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
binjin
Hello stevenjb, Could please take a look at this CL? -bjin
6 years, 2 months ago (2014-10-15 01:41:26 UTC) #2
stevenjb (google-dont-use)
lgtm
6 years, 2 months ago (2014-10-16 17:56:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654093003/1
6 years, 2 months ago (2014-10-16 17:58:17 UTC) #6
binjin
On 2014/10/16 17:56:31, stevenjb (google-dont-use) wrote: > lgtm Sorry for bothering, but could you use ...
6 years, 2 months ago (2014-10-16 17:59:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18110)
6 years, 2 months ago (2014-10-16 18:07:04 UTC) #9
stevenjb
Ugh, sorry. lgtm.
6 years, 2 months ago (2014-10-16 18:12:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654093003/1
6 years, 2 months ago (2014-10-16 18:16:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 18:21:42 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 18:22:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac59b2cc31ddb0bf15074e6253fbf73196a39d69
Cr-Commit-Position: refs/heads/master@{#299933}

Powered by Google App Engine
This is Rietveld 408576698