Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issue 654073002: ozone: evdev: Dispatch key events from gestures devices (Closed)

Created:
6 years, 2 months ago by spang
Modified:
6 years, 2 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Dispatch key events from gestures devices This fixes keypresses on Logitech K400. There's no key repeat yet. BUG=412996 Committed: https://crrev.com/3cfd0dcae37b34350bf94c0821c2e91b4ed43833 Cr-Commit-Position: refs/heads/master@{#300340}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : mismerge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 5 chunks +10 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 4 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
spang
6 years, 2 months ago (2014-10-14 20:37:24 UTC) #2
kpschoedel
LGTM with same nit about std::bitset rather than roll-our-own.
6 years, 2 months ago (2014-10-14 21:25:23 UTC) #3
spang
On 2014/10/14 21:25:23, kpschoedel wrote: > LGTM with same nit about std::bitset rather than roll-our-own. ...
6 years, 2 months ago (2014-10-14 21:40:13 UTC) #4
kpschoedel
On 2014/10/14 21:40:13, spang wrote: > On 2014/10/14 21:25:23, kpschoedel wrote: > > LGTM with ...
6 years, 2 months ago (2014-10-14 21:45:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654073002/40001
6 years, 2 months ago (2014-10-20 20:09:58 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-20 21:48:37 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 21:49:29 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3cfd0dcae37b34350bf94c0821c2e91b4ed43833
Cr-Commit-Position: refs/heads/master@{#300340}

Powered by Google App Engine
This is Rietveld 408576698