Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 654063002: Switch webkitpy to use the typ test framework (delete webkitpy.test). (Closed)

Created:
6 years, 2 months ago by Dirk Pranke
Modified:
6 years, 2 months ago
Reviewers:
ojan
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Switch webkitpy to use the typ test framework (delete webkitpy.test). R=ojan@chromium.org BUG=402172 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184383

Patch Set 1 #

Total comments: 1

Patch Set 2 : set current working dir correctly #

Patch Set 3 : rework to account for the win32 multiprocessing bootstrapping issues #

Patch Set 4 : merge to typ v0.8.6 #

Patch Set 5 : fix typo for bot_test_expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1167 lines) Patch
M Tools/Scripts/test-webkitpy View 1 2 3 4 1 chunk +35 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/executive_unittest.py View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/outputcapture.py View 2 chunks +1 line, -7 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
D Tools/Scripts/webkitpy/test/__init__.py View 3 1 chunk +0 lines, -1 line 0 comments Download
D Tools/Scripts/webkitpy/test/finder.py View 1 chunk +0 lines, -173 lines 0 comments Download
D Tools/Scripts/webkitpy/test/finder_unittest.py View 1 chunk +0 lines, -126 lines 0 comments Download
D Tools/Scripts/webkitpy/test/main.py View 3 1 chunk +0 lines, -218 lines 0 comments Download
D Tools/Scripts/webkitpy/test/main_unittest.py View 1 chunk +0 lines, -107 lines 0 comments Download
D Tools/Scripts/webkitpy/test/printer.py View 1 chunk +0 lines, -212 lines 0 comments Download
D Tools/Scripts/webkitpy/test/runner.py View 1 chunk +0 lines, -90 lines 0 comments Download
D Tools/Scripts/webkitpy/test/runner_unittest.py View 1 chunk +0 lines, -100 lines 0 comments Download
D Tools/Scripts/webkitpy/test/skip.py View 1 chunk +0 lines, -52 lines 0 comments Download
D Tools/Scripts/webkitpy/test/skip_unittest.py View 1 chunk +0 lines, -74 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
lgtm https://codereview.chromium.org/654063002/diff/1/Tools/Scripts/test-webkitpy File Tools/Scripts/test-webkitpy (right): https://codereview.chromium.org/654063002/diff/1/Tools/Scripts/test-webkitpy#newcode41 Tools/Scripts/test-webkitpy:41: # TODO: typ should support some way to ...
6 years, 2 months ago (2014-10-14 23:41:19 UTC) #1
Dirk Pranke
On 2014/10/14 23:41:19, ojan-only-code-yellow-reviews wrote: > https://codereview.chromium.org/654063002/diff/1/Tools/Scripts/test-webkitpy#newcode41 > Tools/Scripts/test-webkitpy:41: # TODO: typ should support some ...
6 years, 2 months ago (2014-10-15 00:18:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654063002/80001
6 years, 2 months ago (2014-10-24 20:46:53 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 20:51:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 184383

Powered by Google App Engine
This is Rietveld 408576698