Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 654013003: Implement invalidation tracking in devtools (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address reviewer comments, update how stacks are handled Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/Source/devtools/front_end/timeline/TimelineUIUtils.js b/Source/devtools/front_end/timeline/TimelineUIUtils.js
index 25ccc57760f18413c77dc9640d3b575dbde0ef4d..6509daed8f56f59c5a8b90a7a60eb55fc7c901c2 100644
--- a/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -562,8 +562,16 @@ WebInspector.TimelineDetailsContentHelper.prototype = {
var rowElement = this.element.createChild("div", "timeline-details-view-row");
rowElement.createChild("span", "timeline-details-view-row-title").textContent = WebInspector.UIString("%s: ", title);
- var stackTraceElement = rowElement.createChild("div", "timeline-details-view-row-stack-trace monospace");
+ this.createChildStackTraceElement(rowElement, stackTrace);
+ },
+ /**
+ * @param {!Element} parentElement
+ * @param {!Array.<!ConsoleAgent.CallFrame>} stackTrace
+ */
+ createChildStackTraceElement: function(parentElement, stackTrace)
+ {
+ var stackTraceElement = parentElement.createChild("div", "timeline-details-view-row-stack-trace monospace");
for (var i = 0; i < stackTrace.length; ++i) {
var stackFrame = stackTrace[i];
var row = stackTraceElement.createChild("div");

Powered by Google App Engine
This is Rietveld 408576698