Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: Source/core/inspector/InspectorTraceEvents.cpp

Issue 654013003: Implement invalidation tracking in devtools (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update test for landing Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorTraceEvents.cpp
diff --git a/Source/core/inspector/InspectorTraceEvents.cpp b/Source/core/inspector/InspectorTraceEvents.cpp
index bbc5ca8388989eadb651af5641f7a17bcded07f2..1b2e8c11b0fa39dc6e48f5e6392a5fe6a834c3c0 100644
--- a/Source/core/inspector/InspectorTraceEvents.cpp
+++ b/Source/core/inspector/InspectorTraceEvents.cpp
@@ -115,6 +115,8 @@ PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorStyleRecalcInvalidatio
setNodeInfo(value.get(), node, "nodeId", "nodeName");
value->setString("reason", reason.reasonString());
value->setString("extraData", reason.extraData());
+ if (RefPtrWillBeRawPtr<ScriptCallStack> stackTrace = createScriptCallStack(maxInvalidationTrackingCallstackSize, true))
+ value->setArray("stackTrace", stackTrace->buildInspectorArray()->asArray());
aandrey 2014/10/21 08:34:49 FYI, stackTrace also contains async stack trace, s
return value.release();
}
@@ -180,8 +182,8 @@ PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorLayoutInvalidationTrac
RefPtr<TracedValue> value = TracedValue::create();
value->setString("frame", toHexString(renderer->frame()));
setGeneratingNodeInfo(value.get(), renderer, "nodeId", "nodeName");
- RefPtrWillBeRawPtr<ScriptCallStack> callstack = createScriptCallStack(maxInvalidationTrackingCallstackSize, true);
- value->setString("callstack", callstack ? callstack->buildInspectorArray()->toJSONString() : "[]");
+ if (RefPtrWillBeRawPtr<ScriptCallStack> stackTrace = createScriptCallStack(maxInvalidationTrackingCallstackSize, true))
+ value->setArray("stackTrace", stackTrace->buildInspectorArray()->asArray());
return value.release();
}
« no previous file with comments | « LayoutTests/inspector/tracing/timeline-style-recalc-invalidations-expected.txt ('k') | Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698