Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Issue 653993005: Fix out-of-bounds read in SourcePositionToScriptPosition with --hydrogen-track-positions. (Closed)

Created:
6 years, 2 months ago by Vyacheslav Egorov (Chromium)
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix out-of-bounds read in SourcePositionToScriptPosition with --hydrogen-track-positions. We were indexing into the list of inlined functions with inlining ID, which is incorrect. There can be multiple inlinining IDs corresponding to the same inlined function, because inlining ID is inlining path sensitive unique id for an inlining attempt. Additionally allow HAbnormalExit to have unknown source position even if we are tracking source positions. No code is generated from abnormal exits anyways. R=svenpanne@chromium.org BUG=v8:3184 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
6 years, 2 months ago (2014-10-15 11:04:28 UTC) #1
Sven Panne
lgtm
6 years, 2 months ago (2014-10-15 11:23:22 UTC) #2
Vyacheslav Egorov (Chromium)
6 years, 2 months ago (2014-10-15 12:06:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24629 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698