Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 653933003: Resubmit: Rename BrowserActionView to ToolbarActionView (Closed)

Created:
6 years, 2 months ago by Devlin
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Resubmit: Rename BrowserActionView to ToolbarActionView Original was reverted due to a bad merge. Rename BrowserActionView to ToolbarActionView BrowserActionViews now represent significantly more than just Browser Actions. Rename it to ToolbarActionView. BUG=426448 TBR=sky@chromium.org Committed: https://crrev.com/131ad133510323eeaf72b408c1e3b2fd14ab8990 Cr-Commit-Position: refs/heads/master@{#302179}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -663 lines) Patch
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc View 3 chunks +9 lines, -9 lines 0 comments Download
D chrome/browser/ui/views/toolbar/browser_action_view.h View 1 chunk +0 lines, -163 lines 0 comments Download
D chrome/browser/ui/views/toolbar/browser_action_view.cc View 1 1 chunk +0 lines, -284 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 10 chunks +37 lines, -39 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 29 chunks +71 lines, -71 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/toolbar/chevron_menu_button.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/toolbar/toolbar_action_view.h View 5 chunks +18 lines, -25 lines 0 comments Download
A + chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 1 11 chunks +34 lines, -34 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653933003/60001
6 years, 1 month ago (2014-10-30 22:00:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 1 month ago (2014-10-30 22:48:39 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 22:49:14 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/131ad133510323eeaf72b408c1e3b2fd14ab8990
Cr-Commit-Position: refs/heads/master@{#302179}

Powered by Google App Engine
This is Rietveld 408576698