Chromium Code Reviews
Help | Chromium Project | Sign in
(568)

Issue 6539018: CHROMIUM: Add gobi driver. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Elly Jones
Modified:
4 years ago
CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, sleffler+cc_chromium.org, msb+croskernel_chromium.org
Visibility:
Public.

Description

CHROMIUM: Add gobi driver. (It isn't built yet, so this should have no functional changes at all). BUG=chromium-os:5521 TEST=suite_Cellular Change-Id: I28bc550bd600ba350f8b34926e698bbb2b3c8c6c Signed-off-by: Elly Jones <ellyjones@chromium.org>; Signed-off-by: Jason Glasgow <jglasgow@chromium.org>; Signed-off-by: Olof Johansson <olofj@chromium.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7e33652

Patch Set 1 #

Patch Set 2 : Merge up to qcom 1.0.40 #

Patch Set 3 : Remove config changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2856 lines, -1 line) Patch
M drivers/net/usb/Kconfig View 1 chunk +6 lines, -0 lines 0 comments Download
M drivers/net/usb/Makefile View 1 chunk +1 line, -1 line 0 comments Download
A drivers/net/usb/gobi/Makefile View 1 chunk +2 lines, -0 lines 0 comments Download
A drivers/net/usb/gobi/README View 1 chunk +30 lines, -0 lines 0 comments Download
A drivers/net/usb/gobi/qcusbnet.h View 1 chunk +24 lines, -0 lines 0 comments Download
A drivers/net/usb/gobi/qcusbnet.c View 1 chunk +649 lines, -0 lines 0 comments Download
A drivers/net/usb/gobi/qmi.h View 1 chunk +67 lines, -0 lines 0 comments Download
A drivers/net/usb/gobi/qmi.c View 1 chunk +358 lines, -0 lines 0 comments Download
A drivers/net/usb/gobi/qmidevice.h View 1 chunk +35 lines, -0 lines 0 comments Download
A drivers/net/usb/gobi/qmidevice.c View 1 1 chunk +1592 lines, -0 lines 0 comments Download
A drivers/net/usb/gobi/structs.h View 1 chunk +92 lines, -0 lines 0 comments Download
Trybot results:
Project "None" does not have a commit queue.

Messages

Total messages: 8 (0 generated)
Elly Jones
4 years, 6 months ago (2011-02-17 18:16:33 UTC) #1
Elly Jones
On 2011/02/17 18:16:33, Elly Jones wrote: Beep?
4 years, 6 months ago (2011-02-23 15:26:58 UTC) #2
Mandeep Singh Baines
Don't make config and code changes in the same CL. Shouldn't this go into for ...
4 years, 6 months ago (2011-02-23 16:51:55 UTC) #3
Elly Jones
This change adds only the disabled config option (i.e., "# CONFIG_USB_NET_GOBI is not set"). Is ...
4 years, 6 months ago (2011-02-23 18:46:08 UTC) #4
Olof Johansson
The main to do them separately is because we rebase config files separately from code ...
4 years, 6 months ago (2011-02-23 19:46:47 UTC) #5
Olof Johansson
Hi, 1) Please separate out config update to a separate CL, even though it's trivial ...
4 years, 5 months ago (2011-03-08 20:38:15 UTC) #6
Olof Johansson
LGTM
4 years, 5 months ago (2011-03-08 22:36:30 UTC) #7
jglasgow
4 years, 5 months ago (2011-03-09 14:22:47 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c33a7a4