Chromium Code Reviews
Help | Chromium Project | Sign in
(811)

Issue 6539018: CHROMIUM: Add gobi driver. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by Elly Jones
Modified:
2 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, sleffler+cc_chromium.org, msb+croskernel_chromium.org
Visibility:
Public.

Description

CHROMIUM: Add gobi driver.

(It isn't built yet, so this should have no functional changes at all).

BUG=chromium-os:5521
TEST=suite_Cellular

Change-Id: I28bc550bd600ba350f8b34926e698bbb2b3c8c6c
Signed-off-by: Elly Jones <ellyjones@chromium.org>;
Signed-off-by: Jason Glasgow <jglasgow@chromium.org>;
Signed-off-by: Olof Johansson <olofj@chromium.org>;

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7e33652

Patch Set 1 #

Patch Set 2 : Merge up to qcom 1.0.40 #

Patch Set 3 : Remove config changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2856 lines, -1 line) Lint Patch
M drivers/net/usb/Kconfig View 1 chunk +6 lines, -0 lines 0 comments ? errors Download
M drivers/net/usb/Makefile View 1 chunk +1 line, -1 line 0 comments ? errors Download
A drivers/net/usb/gobi/Makefile View 1 chunk +2 lines, -0 lines 0 comments ? errors Download
A drivers/net/usb/gobi/README View 1 chunk +30 lines, -0 lines 0 comments ? errors Download
A drivers/net/usb/gobi/qcusbnet.h View 1 chunk +24 lines, -0 lines 0 comments 1 errors Download
A drivers/net/usb/gobi/qcusbnet.c View 1 chunk +649 lines, -0 lines 0 comments 480 errors Download
A drivers/net/usb/gobi/qmi.h View 1 chunk +67 lines, -0 lines 0 comments 17 errors Download
A drivers/net/usb/gobi/qmi.c View 1 chunk +358 lines, -0 lines 0 comments 249 errors Download
A drivers/net/usb/gobi/qmidevice.h View 1 chunk +35 lines, -0 lines 0 comments 4 errors Download
A drivers/net/usb/gobi/qmidevice.c View 1 1 chunk +1592 lines, -0 lines 0 comments 1245 errors Download
A drivers/net/usb/gobi/structs.h View 1 chunk +92 lines, -0 lines 0 comments 45 errors Download
Trybot results:
Commit:

Messages

Total messages: 8
Elly Jones
3 years, 1 month ago #1
Elly Jones
On 2011/02/17 18:16:33, Elly Jones wrote: Beep?
3 years, 1 month ago #2
Mandeep Singh Baines
Don't make config and code changes in the same CL. Shouldn't this go into for ...
3 years, 1 month ago #3
Elly Jones
This change adds only the disabled config option (i.e., "# CONFIG_USB_NET_GOBI is not set"). Is ...
3 years, 1 month ago #4
Olof Johansson
The main to do them separately is because we rebase config files separately from code ...
3 years, 1 month ago #5
Olof Johansson
Hi, 1) Please separate out config update to a separate CL, even though it's trivial ...
3 years, 1 month ago #6
Olof Johansson
LGTM
3 years, 1 month ago #7
jglasgow
3 years, 1 month ago #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434