Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 653893002: Version 3.29.88.8 (merged r24189, r24226, r24271) (Closed)

Created:
6 years, 2 months ago by Weiliang
Modified:
6 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Version 3.29.88.8 (merged r24189, r24226, r24271) X87: fixed branch distances. X87: fix the bug which is introduced by R24169. X87: fix the Sqrt issue. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -16 lines) Patch
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 3 chunks +65 lines, -11 lines 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +8 lines, -2 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Weiliang
6 years, 2 months ago (2014-10-14 08:50:50 UTC) #1
Jakob Kummerow
lgtm
6 years, 2 months ago (2014-10-14 08:51:55 UTC) #2
Weiliang
Hi Jakob, sorry for another merge due to x87 debug test failure at 3.29 branch. ...
6 years, 2 months ago (2014-10-14 08:52:20 UTC) #4
Weiliang
Committed patchset #1 (id:1) manually as 24586.
6 years, 2 months ago (2014-10-14 08:53:05 UTC) #5
Weiliang
Hi Jakob, The merge script fails as below. Do you know how to fix it? ...
6 years, 2 months ago (2014-10-14 09:07:31 UTC) #7
Michael Achenbach
6 years, 2 months ago (2014-10-14 09:15:38 UTC) #8
Message was sent while issue was closed.
The merge script is simply a pain when restarted in the middle, as you are on
another branch and use an older version of the script itself. The script changes
over time and refers to state that is not there now... the only fix here is to
copy the newest version of the script from master into a different folder
outside version control to restart a step (best copy the whole
tools/push-to-trunk folder to e.g. tools/push-to-trunk-pinned).

Powered by Google App Engine
This is Rietveld 408576698