Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 653883004: Create child window using WS_EX_NOPARENTNOTIFY for WGL. (Closed)

Created:
6 years, 2 months ago by jbauman
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Create child window using WS_EX_NOPARENTNOTIFY for WGL. Using WS_EX_NOPARENTNOTIFY seems to resolve the deadlock and allows WGL to work. BUG=273220 Committed: https://crrev.com/9e65c63731b859aa255753ac8ca265a0da00e349 Cr-Commit-Position: refs/heads/master@{#299832}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -21 lines) Patch
M ui/gl/gl_surface_wgl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_surface_wgl.cc View 5 chunks +60 lines, -21 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
jbauman
Seems like this is the simplest solution for getting WGL to work.
6 years, 2 months ago (2014-10-16 00:18:36 UTC) #2
Ken Russell (switch to Gerrit)
LGTM if this has been tested. Thanks for fixing this. https://codereview.chromium.org/653883004/diff/1/ui/gl/gl_surface_wgl.cc File ui/gl/gl_surface_wgl.cc (right): https://codereview.chromium.org/653883004/diff/1/ui/gl/gl_surface_wgl.cc#newcode102 ...
6 years, 2 months ago (2014-10-16 00:58:47 UTC) #3
jbauman
On 2014/10/16 00:58:47, Ken Russell wrote: > LGTM if this has been tested. Thanks for ...
6 years, 2 months ago (2014-10-16 01:02:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653883004/1
6 years, 2 months ago (2014-10-16 01:17:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 03:28:27 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 03:29:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e65c63731b859aa255753ac8ca265a0da00e349
Cr-Commit-Position: refs/heads/master@{#299832}

Powered by Google App Engine
This is Rietveld 408576698