Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
 
 import re

[M-A Ruel, 2014/10/14 14:38:20]

I know it's not your fault but it's really time to remove this. Please move to
inside GetPreferredTryMasters() then fix any remaining caller to use
input_api.re.

[MRV, 2014/10/15 08:49:58]

Done.

 import sys

[M-A Ruel, 2014/10/14 14:38:20]

Same. sys.executable is accessible through input_api.executable.

[MRV, 2014/10/15 08:49:58]

I moved the "import sys", whereveer it required, now.

Before that I have tried:
use input_api.executable inplace of sys.executable, then i got following error.
AttributeError: 'InputApi' object has no attribute 'executable'

For sys.path I have tried following 
input_api.path
input_api.excutable.path
but none worked.

I thought input_api.os_path might not be appropriate to use.

Please suggest me is it fine or do i need to do in any other way.

 
 
 _EXCLUDED_PATHS = (
     r"^breakpad[\\\/].*",
     r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_rules.py",
     r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_simple.py",
     r"^native_client_sdk[\\\/]src[\\\/]tools[\\\/].*.mk",
     r"^net[\\\/]tools[\\\/]spdyshark[\\\/].*",
     r"^skia[\\\/].*",
     r"^v8[\\\/].*",
@@ skipping 1227 matching lines @@
   file_filter = lambda f: input_api.FilterSourceFile(
       f, white_list=file_inclusion_pattern, black_list=black_list)
   for fpath in input_api.AffectedFiles(file_filter=file_filter):
     for line_num, line in fpath.ChangedContents():
       for (deprecated_value, value) in _DEPRECATED_CSS:
         if input_api.re.search(deprecated_value, line):
           results.append(output_api.PresubmitError(
               "%s:%d: Use of deprecated CSS %s, use %s instead" %
               (fpath.LocalPath(), line_num, deprecated_value, value)))
   return results
 

[M-A Ruel, 2014/10/14 14:38:20]

two lines between file level symbols.

[MRV, 2014/10/15 08:49:58]

Done.

+def _CheckForOverrideAndFinalRules(input_api, output_api):
+  """Checks for override and final used as per C++11"""
+  problems = []
+  for f in input_api.AffectedFiles():
+    if (f.LocalPath().endswith(('.cc', '.mm', '.cpp', '.h'))):
+      for line_num, line in f.ChangedContents():
+        if (re.search(r"\bOVERRIDE\b", line) or

[M-A Ruel, 2014/10/14 14:38:20]

input_api.re.search(r"\b(FINAL|OVERRIDE)\b", line)

[MRV, 2014/10/15 08:49:58]

Done.

+            re.search(r"\bFINAL\b", line)):
+          problems.append('    %s:%d' % (f.LocalPath(), line_num))
+
+  if not problems:
+    return []
+  return [output_api.PresubmitError('Use C++11\'s |override| and'

[M-A Ruel, 2014/10/14 14:38:20]

Weird alignment, either all align to "(" or align at +4 (my preference).

[MRV, 2014/10/15 08:49:58]

Done.

+      ' |final| rather than OVERRIDE and FINAL. \n' +

[M-A Ruel, 2014/10/14 14:38:20]

Use '%s' instead of '+'

[MRV, 2014/10/15 08:49:58]

I am using displaying the errors directly now.

+      '\n'.join(problems))]
+
+
 def _CommonChecks(input_api, output_api):
   """Checks common to both upload and commit."""
   results = []
   results.extend(input_api.canned_checks.PanProjectChecks(
       input_api, output_api,
       excluded_paths=_EXCLUDED_PATHS + _TESTRUNNER_PATHS))
   results.extend(_CheckAuthorizedAuthor(input_api, output_api))
   results.extend(
       _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api))
   results.extend(_CheckNoIOStreamInHeaders(input_api, output_api))
@@ skipping 21 matching lines @@
           input_api,
           output_api,
           source_file_filter=lambda x: x.LocalPath().endswith('.grd')))
   results.extend(_CheckSpamLogging(input_api, output_api))
   results.extend(_CheckForAnonymousVariables(input_api, output_api))
   results.extend(_CheckCygwinShell(input_api, output_api))
   results.extend(_CheckUserActionUpdate(input_api, output_api))
   results.extend(_CheckNoDeprecatedCSS(input_api, output_api))
   results.extend(_CheckParseErrors(input_api, output_api))
   results.extend(_CheckForIPCRules(input_api, output_api))
+  results.extend(_CheckForOverrideAndFinalRules(input_api, output_api))
 
   if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()):
     results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
         input_api, output_api,
         input_api.PresubmitLocalPath(),
         whitelist=[r'^PRESUBMIT_test\.py$']))
   return results
 
 
 def _CheckAuthorizedAuthor(input_api, output_api):
@@ skipping 402 matching lines @@
     builders.extend(['cros_x86'])
 
   # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
   # unless they're .gyp(i) files as changes to those files can break the gyp
   # step on that bot.
   if (not all(re.search('^chrome', f) for f in files) or
       any(re.search('\.gypi?$', f) for f in files)):
     builders.extend(['android_aosp'])
 
   return GetDefaultTryConfigs(builders)