Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard

PRESUBMIT_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import glob
 import json
 import os
 import re
 import subprocess
@@ skipping 395 matching lines @@
     self.assertTrue(':1 OS_WINDOWS' in errors[0])
     self.assertTrue('(did you mean OS_WIN?)' in errors[0])
 
   def testValidOSMacroNames(self):
     lines = ['#if defined(%s)' % m for m in PRESUBMIT._VALID_OS_MACROS]
     errors = PRESUBMIT._CheckForInvalidOSMacrosInFile(
         MockInputApi(), MockFile('some/path/foo_platform.cc', lines))
     self.assertEqual(0, len(errors))
 
 
+class InvalidOverideAndFinalTest(unittest.TestCase):
+  def testValidOverrideConstructs(self):
+    mock_input_api = MockInputApi()
+    lines = ['foo1() override;',
+             'foo2() final;',
+             '#DEFINE OVERRIDE_METHOD_OVERLOAD',
+             '#DEFINE FINAL_METHOD',
+             '#DEFINE OVERRIDE_OVERRIDE_SOMETHING',
+             '#DEFINE SOMETHING_OVERRIDE_SOMETHING',
+             '#DEFINE SOMETHING_SOMETHING_OVERRIDE',
+             '#DEFINE FINAL_OVERRIDE_FINAL',
+             '#DEFINE SOMETHING_OVERRIDE_FINAL',
+             '#DEFINE OVERRIDE_OVERRIDE_OVERRIDE',
+             '#endif  // FINAL_METHOD',
+             '#endif  // OVERRIDE_METHOD_OVERLOAD']
+    mock_file_h = MockFile('something.h', lines)
+    mock_input_api.files = [mock_file_h]
+    errors = PRESUBMIT._CheckForOverrideAndFinalRules(mock_input_api,
+                                                      MockOutputApi())
+    self.assertEqual(0, len(errors))
+
+  def testInvalidOverrideConstructsInHeaders(self):
+    mock_input_api = MockInputApi()
+    lines_h = ['foo1() OVERRIDE;']
+    lines_cpp =  ['foo2() FINAL;']

[M-A Ruel, 2014/10/15 15:22:19]

Please fix spacing everywhere to be consistent. You changed lines_cc to
lines_cpp but didn't change what I asked you to.

[MRV, 2014/10/15 17:06:12]

SOn 2014/10/15 15:22:19, M-A Ruel wrote:
Done.
I misunderstood your comment, in previous patch-set, I had something.cpp with
lines_h and something.h with lines_cc, i have corrected those.
In new patch-set i have taken spaces issues.

+    mock_file_cpp= MockFile('something.cpp', lines_cpp)
+    mock_file_h = MockFile('something.h', lines_h)
+    mock_input_api.files = [mock_file_h, mock_file_cpp]
+    errors = PRESUBMIT._CheckForOverrideAndFinalRules(mock_input_api,
+                                                      MockOutputApi())
+    self.assertEqual(1, len(errors))
+
+  def testInvalidOverrideConstructsInCpp(self):
+    mock_input_api = MockInputApi()
+    lines_cpp = ['foo2() FINAL;']
+    mock_file_cpp= MockFile('something.cpp', lines_cpp)
+    mock_input_api.files = [mock_file_cpp]
+    errors = PRESUBMIT._CheckForOverrideAndFinalRules(mock_input_api,
+                                                      MockOutputApi())
+    self.assertEqual(1, len(errors))
+
+  def testInvalidOverrideConstructsInCc(self):
+    mock_input_api = MockInputApi()
+    lines_cc = ['foo3() override FINAL;']
+    mock_file_cc = MockFile('something.cc', lines_cc)
+    mock_input_api.files = [mock_file_cc]
+    errors = PRESUBMIT._CheckForOverrideAndFinalRules(mock_input_api,
+                                                      MockOutputApi())
+    self.assertEqual(1, len(errors))
+
+  def testInvalidOverrideConstructsInMm(self):
+    mock_input_api = MockInputApi()
+    lines_mm = ['foo4() OVERRIDE final;']
+    mock_file_mm = MockFile('something.mm', lines_mm)
+    mock_input_api.files = [mock_file_mm]
+    errors = PRESUBMIT._CheckForOverrideAndFinalRules(mock_input_api,
+                                                      MockOutputApi())
+    self.assertEqual(1, len(errors))
+
+
 class InvalidIfDefinedMacroNamesTest(unittest.TestCase):
   def testInvalidIfDefinedMacroNames(self):
     lines = ['#if defined(TARGET_IPHONE_SIMULATOR)',
              '#if !defined(TARGET_IPHONE_SIMULATOR)',
              '#elif defined(TARGET_IPHONE_SIMULATOR)',
              '#ifdef TARGET_IPHONE_SIMULATOR',
              ' # ifdef TARGET_IPHONE_SIMULATOR',
              '# if defined(VALID) || defined(TARGET_IPHONE_SIMULATOR)',
              '# else  // defined(TARGET_IPHONE_SIMULATOR)',
              '#endif  // defined(TARGET_IPHONE_SIMULATOR)',]
@@ skipping 352 matching lines @@
     }
     for master, bots in bots.iteritems():
       for bot in bots:
         self.assertEqual(master, PRESUBMIT.GetTryServerMasterForBot(bot),
                          'bot=%s: expected %s, computed %s' % (
             bot, master, PRESUBMIT.GetTryServerMasterForBot(bot)))
 
 
 if __name__ == '__main__':
   unittest.main()