Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 653863003: Adding instrumentation to locate the source of jankiness. (Closed)

Created:
6 years, 2 months ago by vadimt
Modified:
6 years, 2 months ago
Reviewers:
vadimt1
CC:
chromium-reviews, michaeln, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, gavinp, Yoyo Zhou, danakj, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding instrumentation to locate the source of jankiness. Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. Landing as TBR since this is a mechanical, safe and temporary change. BUG=422489 TBR=gavinp@chromium.org, yoz@chromium.org, danakj@chromium.org, michaeln@chromium.org, piman@chromium.org Committed: https://crrev.com/2ad71571d47dea2dfef40f9c8f2a16440012b142 Cr-Commit-Position: refs/heads/master@{#300109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M chrome/browser/extensions/chrome_url_request_util.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/appcache/view_appcache_internals_job.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M content/browser/histogram_internals_request_job.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/tcmalloc_internals_request_job.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M extensions/browser/extension_protocols.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/url_request/url_request_data_job.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M net/url_request/url_request_simple_job.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M storage/browser/blob/view_blob_internals_job.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653863003/1
6 years, 2 months ago (2014-10-17 01:17:53 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/24537)
6 years, 2 months ago (2014-10-17 03:05:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653863003/1
6 years, 2 months ago (2014-10-17 14:35:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 15:05:11 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 15:05:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ad71571d47dea2dfef40f9c8f2a16440012b142
Cr-Commit-Position: refs/heads/master@{#300109}

Powered by Google App Engine
This is Rietveld 408576698