Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 653853004: athena: Avoid initializaing chromeos::Network for tests. (Closed)

Created:
6 years, 2 months ago by sadrul
Modified:
6 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

athena: Avoid initializaing chromeos::Network for tests. Initializaing chromeos::Network triggers a whole bunch of things that are not necessary or useful in tests. So avoid initializing this subsystem, since none of the tests depend on it. Tests that do depend on this in the future should explicitly initialize this from SetUp(). This change brings down the runtime of athena_unittests significantly. BUG=412535 R=oshima@chromium.org Committed: https://crrev.com/9ac6e8a2e435f3e732996c57840fb109b5cc4f6e Cr-Commit-Position: refs/heads/master@{#300491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M athena/system/status_icon_container_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M athena/test/base/athena_test_helper.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sadrul
6 years, 2 months ago (2014-10-20 21:52:52 UTC) #2
oshima
lgtm
6 years, 2 months ago (2014-10-21 00:15:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9ac6e8a2e435f3e732996c57840fb109b5cc4f6e Cr-Commit-Position: refs/heads/master@{#300491}
6 years, 2 months ago (2014-10-21 15:44:11 UTC) #4
sadrul
6 years, 2 months ago (2014-10-21 15:44:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9ac6e8a2e435f3e732996c57840fb109b5cc4f6e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698