[GCM] Start GCMChannelStatusSyncer when GCM is disabled

components/gcm_driver/gcm_channel_status_request.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_GCM_DRIVER_GCM_CHANNEL_STATUS_REQUEST_H_
 #define COMPONENTS_GCM_DRIVER_GCM_CHANNEL_STATUS_REQUEST_H_
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "net/base/backoff_entry.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request_context_getter.h"
 
 namespace net {
 class URLRequestContextGetter;
 }
 
 namespace gcm {
 
 // Defines the request to talk with the server to determine if the GCM support
 // should be enabled.
 class GCMChannelStatusRequest : public net::URLFetcherDelegate {
  public:
   // Callback completing the channel status request.
-  typedef base::Callback<void(bool enabled, int poll_interval_seconds)>
+  // |update_received|: use the existing values if it is false which means no
+  //                    update is received.
+  // |enabled|: indicates if GCM should be enabled or not.

[fgorski, 2014/10/14 17:40:37]

nit: or disabled.

Why? One could read that statement as: Should I enable GCM? yes/no, as opposed
to: Is GCM allowed (enabled) to run? yes/no

[jianli, 2014/10/14 23:21:47]

Updated the comment.

+  // |poll_interval_seconds|: the interval in seconds to start next polling

[fgorski, 2014/10/14 17:40:37]

nit: next poll request

[jianli, 2014/10/14 23:21:47]

Done.

+  //                          request.
+  typedef base::Callback<void(bool update_received,
+                              bool enabled,
+                              int poll_interval_seconds)>
       GCMChannelStatusRequestCallback;
 
   GCMChannelStatusRequest(
       const scoped_refptr<net::URLRequestContextGetter>& request_context_getter,
       const std::string& channel_status_request_url,
       const std::string& user_agent,
       const GCMChannelStatusRequestCallback& callback);
   virtual ~GCMChannelStatusRequest();
 
   void Start();
@@ skipping 15 matching lines @@
   scoped_ptr<net::URLFetcher> url_fetcher_;
   net::BackoffEntry backoff_entry_;
   base::WeakPtrFactory<GCMChannelStatusRequest> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GCMChannelStatusRequest);
 };
 
 }  // namespace gcm
 
 #endif  // COMPONENTS_GCM_DRIVER_GCM_CHANNEL_STATUS_REQUEST_H_