Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 653833002: Animation: Composite animations with any start delay specified (Closed)

Created:
6 years, 2 months ago by samli
Modified:
6 years, 2 months ago
Reviewers:
dstockwell
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Animation: Composite animations with any start delay specified BUG=423211 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183647

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M Source/core/animation/CompositorAnimations.cpp View 1 chunk +5 lines, -21 lines 0 comments Download
M Source/core/animation/CompositorAnimationsImpl.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
samli
6 years, 2 months ago (2014-10-14 04:46:05 UTC) #2
dstockwell
lgtm https://codereview.chromium.org/653833002/diff/1/Source/core/animation/CompositorAnimationsImpl.h File Source/core/animation/CompositorAnimationsImpl.h (right): https://codereview.chromium.org/653833002/diff/1/Source/core/animation/CompositorAnimationsImpl.h#newcode49 Source/core/animation/CompositorAnimationsImpl.h:49: ASSERT(std::isfinite(playbackRate)); playbackRate should also not be 0
6 years, 2 months ago (2014-10-14 04:54:10 UTC) #3
samli
https://codereview.chromium.org/653833002/diff/1/Source/core/animation/CompositorAnimationsImpl.h File Source/core/animation/CompositorAnimationsImpl.h (right): https://codereview.chromium.org/653833002/diff/1/Source/core/animation/CompositorAnimationsImpl.h#newcode49 Source/core/animation/CompositorAnimationsImpl.h:49: ASSERT(std::isfinite(playbackRate)); On 2014/10/14 04:54:10, dstockwell wrote: > playbackRate should ...
6 years, 2 months ago (2014-10-14 04:57:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653833002/20001
6 years, 2 months ago (2014-10-14 04:59:10 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 07:01:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183647

Powered by Google App Engine
This is Rietveld 408576698