Mark all chromium test swarming task requests as idempotent.

Mark all chromium test swarming task requests as idempotent.

As the build becomes more and more deterministic, the utilization will lower by
deduping the tasks.

The staging server was previous set as idempotent and we're still fine.

R=vadimsh@chromium.org
BUG=314403
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292620

[Vadim Sh., 2014-10-23 10:38:45]

lgtm

[M-A Ruel, 2014-10-23 12:12:31]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2014-10-23 12:13:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/653793003/1

[commit-bot: I haz the power, 2014-10-23 12:13:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 12:13:43]

Failed to apply patch for
build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
  Hunk #1 FAILED at 284.
  Hunk #2 FAILED at 355.
  2 out of 2 hunks FAILED -- saving rejects to file
build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json.rej

Patch:      
build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
Index: scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
diff --git
build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
index
c0a530a0346983d517c602597e23cd2b48ca94c2..5f84f95d4ad4951401eb72de6470ced88559cec8
100644
---
a/build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
+++
b/build/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
@@ -284,6 +284,7 @@
       "purpose:ManualTS",
       "--tag",
       "purpose:pre-commit",
+      "--idempotent",
       "[dummy hash for base_unittests]",
       "--",
       "--test-launcher-summary-output=${ISOLATED_OUTDIR}/output.json"
@@ -355,6 +356,7 @@
       "purpose:ManualTS",
       "--tag",
       "purpose:pre-commit",
+      "--idempotent",
       "[dummy hash for browser_tests]",
       "--",
       "--test-launcher-summary-output=${ISOLATED_OUTDIR}/output.json"

[M-A Ruel, 2014-10-23 12:18:54]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2014-10-23 12:19:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/653793003/20001

[commit-bot: I haz the power, 2014-10-23 12:20:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 12:20:48]

Presubmit check for 653793003-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
scripts/slave/unittests/recipe_simulation_test.py (31.01s) failed
..............................................................................................................................................................................................................................................................................................................................................F...F.......................F......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

======================================================================
FAIL: chromium.full_client_skia_Mac10_7_Tests__1__Trybot
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium.expected/full_client_skia_Mac10_7_Tests__1__Trybot.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 173,180 ****
--- 173,181 ----
            '--tag',
            'project:chromium',
            '--tag',
            'purpose:CI',
+           '--idempotent',
            'ffffffffffffffffffffffffffffffffffffffff',
            '--',
            '--test-launcher-summary-output=${ISOLATED_OUTDIR}/output.json'],
    'name': '[trigger] browser_tests',

======================================================================
FAIL: chromium.full_client_skia_Linux_Tests_Trybot
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Tests_Trybot.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 173,180 ****
--- 173,181 ----
            '--tag',
            'project:chromium',
            '--tag',
            'purpose:CI',
+           '--idempotent',
            'ffffffffffffffffffffffffffffffffffffffff',
            '--',
            '--test-launcher-summary-output=${ISOLATED_OUTDIR}/output.json'],
    'name': '[trigger] browser_tests',

======================================================================
FAIL: chromium.full_client_skia_Win7_Tests__1__Trybot
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/chromium.expected/full_client_skia_Win7_Tests__1__Trybot.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 178,185 ****
--- 178,186 ----
            '--tag',
            'project:chromium',
            '--tag',
            'purpose:CI',
+           '--idempotent',
            'ffffffffffffffffffffffffffffffffffffffff',
            '--',
            '--test-launcher-summary-output=${ISOLATED_OUTDIR}/output.json'],
    'name': '[trigger] browser_tests',


----------------------------------------------------------------------
Ran 913 tests in 26.475s

FAILED (failures=3)


Presubmit checks took 61.7s to calculate.

[M-A Ruel, 2014-10-23 12:35:12]

cc'ing Eric because it's impacting Skia. As long as Skia tests do not use remote
services (and I don't see why they would), they are fine.

[M-A Ruel, 2014-10-23 12:35:28]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2014-10-23 12:35:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/653793003/40001

[commit-bot: I haz the power, 2014-10-23 12:37:15]

Committed patchset #3 (id:40001) as 292620