Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 653793002: Improve the names used in Mojo JS modules (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
hansmuller
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Improve the names used in Mojo JS modules Previously, we just used ugly numbered names as the local names for modules in JavaScript. Now we try to use a meaningful name based on the name of the module. There shouldn't be any behavior change. R=hansmuller@chromium.org Committed: https://crrev.com/32c970a8e690342135e35f043fcee5330c811027 Cr-Commit-Position: refs/heads/master@{#299413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 chunk +14 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
abarth-chromium
6 years, 2 months ago (2014-10-13 23:18:18 UTC) #1
hansmuller
This LGTM. Glad to see importN go away.
6 years, 2 months ago (2014-10-14 00:08:08 UTC) #2
abarth-chromium
By the way, I noticed in writing this CL that many of these imports aren't ...
6 years, 2 months ago (2014-10-14 01:00:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653793002/1
6 years, 2 months ago (2014-10-14 01:02:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 01:24:50 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 01:25:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32c970a8e690342135e35f043fcee5330c811027
Cr-Commit-Position: refs/heads/master@{#299413}

Powered by Google App Engine
This is Rietveld 408576698