Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: chrome/test/base/tracing.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/testing_profile_manager.cc ('k') | chrome/test/base/ui_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/tracing.cc
diff --git a/chrome/test/base/tracing.cc b/chrome/test/base/tracing.cc
index 8a37ab99948f666d06ba0624bd0eaf8f462cdbd6..6ed0f54a316b92f4a72e9aa2f30b842f93e6a4be 100644
--- a/chrome/test/base/tracing.cc
+++ b/chrome/test/base/tracing.cc
@@ -24,18 +24,18 @@ class StringTraceSink : public content::TracingController::TraceDataSink {
StringTraceSink(std::string* result, const base::Closure& callback)
: result_(result), completion_callback_(callback) {}
- virtual void AddTraceChunk(const std::string& chunk) override {
+ void AddTraceChunk(const std::string& chunk) override {
*result_ += result_->empty() ? "[" : ",";
*result_ += chunk;
}
- virtual void Close() override {
+ void Close() override {
if (!result_->empty())
*result_ += "]";
completion_callback_.Run();
}
private:
- virtual ~StringTraceSink() {}
+ ~StringTraceSink() override {}
std::string* result_;
base::Closure completion_callback_;
« no previous file with comments | « chrome/test/base/testing_profile_manager.cc ('k') | chrome/test/base/ui_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698