Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Unified Diff: chrome/service/cloud_print/printer_job_handler.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/printer_job_handler.h
diff --git a/chrome/service/cloud_print/printer_job_handler.h b/chrome/service/cloud_print/printer_job_handler.h
index 46d29fde308ec58d4e3b27ad3670799ecc5309c8..b5731d88b98fea1cfa972dfc10a081bde3d06747 100644
--- a/chrome/service/cloud_print/printer_job_handler.h
+++ b/chrome/service/cloud_print/printer_job_handler.h
@@ -115,39 +115,39 @@ class PrinterJobHandler : public base::RefCountedThreadSafe<PrinterJobHandler>,
// Begin Delegate implementations
// CloudPrintURLFetcher::Delegate implementation.
- virtual CloudPrintURLFetcher::ResponseAction HandleRawResponse(
+ CloudPrintURLFetcher::ResponseAction HandleRawResponse(
const net::URLFetcher* source,
const GURL& url,
const net::URLRequestStatus& status,
int response_code,
const net::ResponseCookies& cookies,
const std::string& data) override;
- virtual CloudPrintURLFetcher::ResponseAction HandleRawData(
+ CloudPrintURLFetcher::ResponseAction HandleRawData(
const net::URLFetcher* source,
const GURL& url,
const std::string& data) override;
- virtual CloudPrintURLFetcher::ResponseAction HandleJSONData(
+ CloudPrintURLFetcher::ResponseAction HandleJSONData(
const net::URLFetcher* source,
const GURL& url,
base::DictionaryValue* json_data,
bool succeeded) override;
- virtual void OnRequestGiveUp() override;
- virtual CloudPrintURLFetcher::ResponseAction OnRequestAuthError() override;
- virtual std::string GetAuthHeader() override;
+ void OnRequestGiveUp() override;
+ CloudPrintURLFetcher::ResponseAction OnRequestAuthError() override;
+ std::string GetAuthHeader() override;
// JobStatusUpdater::Delegate implementation
- virtual bool OnJobCompleted(JobStatusUpdater* updater) override;
- virtual void OnAuthError() override;
+ bool OnJobCompleted(JobStatusUpdater* updater) override;
+ void OnAuthError() override;
// PrinterWatcherDelegate implementation
- virtual void OnPrinterDeleted() override;
- virtual void OnPrinterChanged() override;
- virtual void OnJobChanged() override;
+ void OnPrinterDeleted() override;
+ void OnPrinterChanged() override;
+ void OnJobChanged() override;
// JobSpoolerDelegate implementation.
// Called on print_thread_.
- virtual void OnJobSpoolSucceeded(const PlatformJobId& job_id) override;
- virtual void OnJobSpoolFailed() override;
+ void OnJobSpoolSucceeded(const PlatformJobId& job_id) override;
+ void OnJobSpoolFailed() override;
// End Delegate implementations
@@ -176,7 +176,7 @@ class PrinterJobHandler : public base::RefCountedThreadSafe<PrinterJobHandler>,
const GURL& url,
const std::string& data);
- virtual ~PrinterJobHandler();
+ ~PrinterJobHandler() override;
// Begin request handlers for each state in the state machine
CloudPrintURLFetcher::ResponseAction HandlePrinterUpdateResponse(
« no previous file with comments | « chrome/service/cloud_print/print_system_cups.cc ('k') | chrome/service/cloud_print/printer_job_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698