Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/app/chrome_crash_reporter_client.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_main_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client.h
diff --git a/chrome/app/chrome_crash_reporter_client.h b/chrome/app/chrome_crash_reporter_client.h
index ddd426b8c29903d2970024bc0f5485385c43bfaa..9ca28180b8977daa9e9127432fe4ed4d002d1a52 100644
--- a/chrome/app/chrome_crash_reporter_client.h
+++ b/chrome/app/chrome_crash_reporter_client.h
@@ -14,10 +14,10 @@ namespace chrome {
class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
public:
ChromeCrashReporterClient();
- virtual ~ChromeCrashReporterClient();
+ ~ChromeCrashReporterClient() override;
// crash_reporter::CrashReporterClient implementation.
- virtual void SetCrashReporterClientIdFromGUID(
+ void SetCrashReporterClientIdFromGUID(
const std::string& client_guid) override;
#if defined(OS_WIN)
virtual bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir)
@@ -45,16 +45,16 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
virtual base::FilePath GetReporterLogFilename() override;
#endif
- virtual bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
+ bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
- virtual size_t RegisterCrashKeys() override;
+ size_t RegisterCrashKeys() override;
- virtual bool IsRunningUnattended() override;
+ bool IsRunningUnattended() override;
- virtual bool GetCollectStatsConsent() override;
+ bool GetCollectStatsConsent() override;
#if defined(OS_WIN) || defined(OS_MACOSX)
- virtual bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override;
+ bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override;
#endif
#if defined(OS_ANDROID)
@@ -62,11 +62,10 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
#endif
#if defined(OS_MACOSX)
- virtual void InstallAdditionalFilters(BreakpadRef breakpad) override;
+ void InstallAdditionalFilters(BreakpadRef breakpad) override;
#endif
- virtual bool EnableBreakpadForProcess(
- const std::string& process_type) override;
+ bool EnableBreakpadForProcess(const std::string& process_type) override;
private:
DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient);
« no previous file with comments | « no previous file | chrome/app/chrome_main_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698