Fixing problem where a session restore gets performed even though users don't want it

Fixing problem where a session restore gets performed even though users don't want it

The problem: In various cases we have seen that the user setting to ignore the restore option (nothing / all) gets ignored.
Examples: Per user command line changes enforce a restart of chrome after login. After update, ...

On ChromeOS we need only to overwrite the user setting when chrome crashed - which would be identified by the commandline option.

I run all browser tests and changed some tests to respect this behavior.

BUG=395925
TEST=existing unit tests

Committed: https://crrev.com/56be508a4a8d5365f8a8207d26e61634e63c0a65
Cr-Commit-Position: refs/heads/master@{#299995}

[Mr4D (OOO till 08-26), 2014-10-15 21:53:53]

skuhne@chromium.org changed reviewers:
+ sky@chromium.org

[Mr4D (OOO till 08-26), 2014-10-15 21:54:27]

I think you are the best reviewer for this change. Maybe I have missed
something...

Many thanks!

[sky, 2014-10-15 23:57:21]

https://codereview.chromium.org/653773003/diff/1/chrome/browser/ui/startup/st...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/653773003/diff/1/chrome/browser/ui/startup/st...
chrome/browser/ui/startup/startup_browser_creator.cc:366: const bool did_restart
= false;
Won't this mean if you change an about:flag and click restart we won't restore
previous settings? What are the specific cases you don't want to honor
WasRestarted?

[sky, 2014-10-16 20:35:27]

LGTM was a better comment.

https://codereview.chromium.org/653773003/diff/1/chrome/browser/ui/startup/st...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/653773003/diff/1/chrome/browser/ui/startup/st...
chrome/browser/ui/startup/startup_browser_creator.cc:366: const bool did_restart
= false;
On 2014/10/15 23:57:20, sky wrote:
> Won't this mean if you change an about:flag and click restart we won't restore
> previous settings? What are the specific cases you don't want to honor
> WasRestarted?

This comment is confusing. I think you mean something like:
On ChromeOS restarts force the user to login again. The expectation is that
after a login the user gets clean state. For this reason we ignore
StartupBrowserCreator::WasRestarted().

[Mr4D (OOO till 08-26), 2014-10-16 20:58:43]

Thanks for your review!

https://codereview.chromium.org/653773003/diff/1/chrome/browser/ui/startup/st...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/653773003/diff/1/chrome/browser/ui/startup/st...
chrome/browser/ui/startup/startup_browser_creator.cc:366: const bool did_restart
= false;
On 2014/10/16 20:35:27, sky wrote:
> On 2014/10/15 23:57:20, sky wrote:
> > Won't this mean if you change an about:flag and click restart we won't
restore
> > previous settings? What are the specific cases you don't want to honor
> > WasRestarted?
> 
> This comment is confusing. I think you mean something like:
> On ChromeOS restarts force the user to login again. The expectation is that
> after a login the user gets clean state. For this reason we ignore
> StartupBrowserCreator::WasRestarted().

Done.

[Mr4D (OOO till 08-26), 2014-10-16 20:58:47]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-16 21:00:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/653773003/20001

[commit-bot: I haz the power, 2014-10-16 22:38:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-16 22:39:25]

Patchset 2 (id:??) landed as
https://crrev.com/56be508a4a8d5365f8a8207d26e61634e63c0a65
Cr-Commit-Position: refs/heads/master@{#299995}