Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 653753004: Reland of [ServiceWorkerCache] Implement storage::QuotaClient (Closed)

Created:
6 years, 2 months ago by jkarlin
Modified:
6 years, 2 months ago
Reviewers:
falken, michaeln
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, dmurph
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland of [ServiceWorkerCache] Implement storage::QuotaClient This is a reland of https://codereview.chromium.org/651983002/ which was reverted as part of bug 424923. It turns out this CL was not related and should reland. BUG=420159 Committed: https://crrev.com/d2d1b62f21b070f9fa14ea66a24feca79f4361c4 Cr-Commit-Position: refs/heads/master@{#300398}

Patch Set 1 : Reverted CL #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Messages

Total messages: 19 (11 generated)
jkarlin
falken@chromium.org: Please review changes in all michaeln@chromium.org: Please review changes in all This is a ...
6 years, 2 months ago (2014-10-20 14:23:35 UTC) #6
michaeln
lgtm (fyi dmurph gearing up to reland too)
6 years, 2 months ago (2014-10-20 20:13:57 UTC) #7
jkarlin
On 2014/10/20 20:13:57, michaeln wrote: > lgtm (fyi dmurph gearing up to reland too) Thanks. ...
6 years, 2 months ago (2014-10-20 20:41:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653753004/100001
6 years, 2 months ago (2014-10-20 20:42:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32 on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32/builds/3114)
6 years, 2 months ago (2014-10-20 20:52:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653753004/180001
6 years, 2 months ago (2014-10-21 00:19:29 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:180001)
6 years, 2 months ago (2014-10-21 01:42:00 UTC) #18
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 01:42:51 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d2d1b62f21b070f9fa14ea66a24feca79f4361c4
Cr-Commit-Position: refs/heads/master@{#300398}

Powered by Google App Engine
This is Rietveld 408576698