Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 653733002: Revert of Mac: Update sheet position when bookmark bar is shown or hidden. (Closed)

Created:
6 years, 2 months ago by Andre
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Mac: Update sheet position when bookmark bar is shown or hidden. (patchset #1 id:1 of https://codereview.chromium.org/502413004/) Reason for revert: Broke certificate info positioning when switching tabs (http://crbug.com/419371). I will need to come up with a better fix for this, but it looks complicated and that bug is a M39 stable blocker so reverting this first. Original issue's description: > Mac: Update sheet position when bookmark bar is shown or hidden. > > In r272421, I changed sheet repositioning on window resize to be based on > NSWindowDidResizeNotification instead of NSViewFrameDidChangeNotification > because it tracks window resizing much more smoothly. > > That caused this problem where if the browser window is vertically maximized > (or is in fullscreen), the window size does not change when the bookmark bar > is shown or hidden. > > The old code has a different bug however. If the browser window is not > vertically maximized, showing or hiding the bookmark bar does not change the > browser content view's frame. It moves up or down to follow the window resize > but its frame relative to its superview remains the same. > > I settled for adding code to explicitly update the sheet's position when the > bookmark bar is shown or hidden. > > BUG=407509 > > Committed: https://crrev.com/5648b809d1c50e3de754b96abe7cf2b60150ff4d > Cr-Commit-Position: refs/heads/master@{#292421} TBR=avi@chromium.org BUG=407509 Committed: https://crrev.com/92af67fd5aa629d7a7fd24418a4098f091bf317b Cr-Commit-Position: refs/heads/master@{#299391}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Andre
Created Revert of Mac: Update sheet position when bookmark bar is shown or hidden.
6 years, 2 months ago (2014-10-13 22:04:01 UTC) #1
Avi (use Gerrit)
On 2014/10/13 22:04:01, Andre wrote: > Created Revert of Mac: Update sheet position when bookmark ...
6 years, 2 months ago (2014-10-13 22:08:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653733002/1
6 years, 2 months ago (2014-10-13 22:13:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/78534) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/68066) win_gpu ...
6 years, 2 months ago (2014-10-13 22:19:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653733002/290001
6 years, 2 months ago (2014-10-13 22:39:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:290001)
6 years, 2 months ago (2014-10-13 23:28:59 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 23:29:53 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92af67fd5aa629d7a7fd24418a4098f091bf317b
Cr-Commit-Position: refs/heads/master@{#299391}

Powered by Google App Engine
This is Rietveld 408576698