Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Issue 653723004: Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/wizard_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
index 40a256a6a2079dde8d403ed757004354d647008a..7330dd0745b7a1ccd1bfcb9fe17f98f79fcb0596 100644
--- a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
@@ -120,15 +120,21 @@
};
struct SwitchLanguageTestData {
- SwitchLanguageTestData() : result("", "", false), done(false) {}
-
- locale_util::LanguageSwitchResult result;
+ SwitchLanguageTestData() : success(false), done(false) {}
+
+ std::string requested_locale;
+ std::string loaded_locale;
+ bool success;
bool done;
};
void OnLocaleSwitched(SwitchLanguageTestData* self,
- const locale_util::LanguageSwitchResult& result) {
- self->result = result;
+ const std::string& locale,
+ const std::string& loaded_locale,
+ const bool success) {
+ self->requested_locale = locale;
+ self->loaded_locale = loaded_locale;
+ self->success = success;
self->done = true;
}
@@ -136,17 +142,18 @@
const std::string& expected_locale,
const bool expect_success) {
SwitchLanguageTestData data;
- locale_util::SwitchLanguageCallback callback(
- base::Bind(&OnLocaleSwitched, base::Unretained(&data)));
- locale_util::SwitchLanguage(locale, true, false, callback);
+ scoped_ptr<locale_util::SwitchLanguageCallback> callback(
+ new locale_util::SwitchLanguageCallback(
+ base::Bind(&OnLocaleSwitched, base::Unretained(&data))));
+ locale_util::SwitchLanguage(locale, true, false, callback.Pass());
// Token writing moves control to BlockingPool and back.
content::RunAllBlockingPoolTasksUntilIdle();
EXPECT_EQ(data.done, true);
- EXPECT_EQ(data.result.requested_locale, locale);
- EXPECT_EQ(data.result.loaded_locale, expected_locale);
- EXPECT_EQ(data.result.success, expect_success);
+ EXPECT_EQ(data.requested_locale, locale);
+ EXPECT_EQ(data.loaded_locale, expected_locale);
+ EXPECT_EQ(data.success, expect_success);
}
void SetUpCrasAndEnableChromeVox(int volume_percent, bool mute_on) {

Powered by Google App Engine
This is Rietveld 408576698