Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 653633005: [WebView] Enable scrolling in fullscreen. (Closed)

Created:
6 years, 2 months ago by Ignacio Solla
Modified:
6 years, 2 months ago
Reviewers:
mkosiba (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org, benm (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[WebView] Enable scrolling in fullscreen. The next step is to fix crbug/423381 to improve transitions from/to fullscreen after scrolling. BUG=398485 Committed: https://crrev.com/4f91ee56e740bc766dfd8964a3adbb776465cf87 Cr-Commit-Position: refs/heads/master@{#300520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -33 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 4 chunks +69 lines, -28 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwViewMethods.java View 1 chunk +41 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/FullScreenView.java View 2 chunks +47 lines, -5 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/NullAwViewMethods.java View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ignacio Solla
6 years, 2 months ago (2014-10-21 12:30:37 UTC) #2
mkosiba (inactive)
lgtm
6 years, 2 months ago (2014-10-21 15:52:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653633005/1
6 years, 2 months ago (2014-10-21 17:09:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 17:59:14 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 18:00:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f91ee56e740bc766dfd8964a3adbb776465cf87
Cr-Commit-Position: refs/heads/master@{#300520}

Powered by Google App Engine
This is Rietveld 408576698