content/browser/service_worker/service_worker_process_manager.h - Issue 653633004: Shutdown Service Workers before the profile is destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_process_manager.h

Issue 653633004: Shutdown Service Workers before the profile is destroyed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_destroyer.cc ('K') | « chrome/browser/profiles/profile_destroyer.cc ('k') | content/public/browser/service_worker_context.h » ('j') | content/public/browser/service_worker_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_process_manager.h

diff --git a/content/browser/service_worker/service_worker_process_manager.h b/content/browser/service_worker/service_worker_process_manager.h

index edfef4232d265172371d483dfcc88d9825d814fc..88563c5b07e52e2e156375ebeb1d14a5feae663a 100644

--- a/content/browser/service_worker/service_worker_process_manager.h

+++ b/content/browser/service_worker/service_worker_process_manager.h

@@ -35,7 +35,7 @@ class CONTENT_EXPORT ServiceWorkerProcessManager {

~ServiceWorkerProcessManager();

// Synchronously prevents new processes from being allocated.

- // TODO(jyasskin): Drop references to RenderProcessHosts too.

+ // and drops references to RenderProcessHosts.

void Shutdown();

// Returns a reference to a running process suitable for starting the Service