Shutdown Service Workers before the profile is destroyed

chrome/browser/profiles/profile.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile.h"
 
 #include <string>
 
 #include "base/prefs/pref_service.h"
 #include "build/build_config.h"
@@ skipping 234 matching lines @@
 
   // No ProfileSyncService created yet - we don't want to create one, so just
   // infer the accessible state by looking at prefs/command line flags.
   sync_driver::SyncPrefs prefs(GetPrefs());
   return ProfileSyncService::IsSyncEnabled() && !prefs.IsManaged();
 }
 
 void Profile::MaybeSendDestroyedNotification() {
   if (!sent_destroyed_notification_) {
     sent_destroyed_notification_ = true;
+
+    NotifyWillBeDestroyed(this);

[jam, 2014/10/23 22:45:22]

we shouldn't have content depend on every embedder knowing to do this or else
something in content (SW) breaks. can you find another way of initiating this
from within content?

[falken, 2014/10/24 00:53:34]

It's actually chrome stuff that's breaking because it expects the Profiles to
outlive RPHs (this particular crash is in ExtensionService). The current code
already depends on chrome shutting down Service Workers in BrowserProcessImpl to
prevent DCHECKs in chrome. This patch moves that special shutdown code to a
place that works for incognito profiles too.

It seems SW needs some signal from the embedder that it's time to shutdown.
Another option may be to change chrome's assumptions about RPH lifetimes, but
I'm not sure how involved that is.

     content::NotificationService::current()->Notify(
         chrome::NOTIFICATION_PROFILE_DESTROYED,
         content::Source<Profile>(this),
         content::NotificationService::NoDetails());
   }
 }
 
 bool ProfileCompare::operator()(Profile* a, Profile* b) const {
   DCHECK(a && b);
   if (a->IsSameProfile(b))
     return false;
   return a->GetOriginalProfile() < b->GetOriginalProfile();
 }