Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 653623002: Revert "Move ExtensionCache to //extensions" (Closed)

Created:
6 years, 2 months ago by kustermann
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Move ExtensionCache to //extensions" This reverts commit 1056c8a4ddb699dec826e75358f554c0e4790ae2. Reason for revert: Seems to have caused test flakiness with non-empty message loop. See https://crbug.com/422884. BUG=422884 TBR=rockot@chromium.org Committed: https://crrev.com/98ff22abeecf0c949bfcbab1a85dcba93f8d2285 Cr-Commit-Position: refs/heads/master@{#299294}

Patch Set 1 #

Patch Set 2 : Enable AutoEnrollmentClientTest.* and DeviceLocalAccountExternalPolicyLoaderTest.CacheNotStarted te… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -277 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc View 1 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc View 1 4 chunks +4 lines, -32 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 4 chunks +5 lines, -18 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
A + chrome/browser/extensions/updater/extension_cache.h View 3 chunks +12 lines, -8 lines 0 comments Download
A chrome/browser/extensions/updater/extension_cache.cc View 1 chunk +84 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/extension_cache_fake.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_cache_fake.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/extension_cache_impl.h View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_cache_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/extensions_browser_client.h View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 4 chunks +0 lines, -7 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.cc View 3 chunks +1 line, -7 lines 0 comments Download
D extensions/browser/updater/extension_cache.h View 1 chunk +0 lines, -63 lines 0 comments Download
D extensions/browser/updater/null_extension_cache.h View 1 chunk +0 lines, -36 lines 0 comments Download
D extensions/browser/updater/null_extension_cache.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.h View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653623002/280001
6 years, 2 months ago (2014-10-13 12:17:01 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:280001)
6 years, 2 months ago (2014-10-13 13:39:19 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 13:39:59 UTC) #4
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/98ff22abeecf0c949bfcbab1a85dcba93f8d2285
Cr-Commit-Position: refs/heads/master@{#299294}

Powered by Google App Engine
This is Rietveld 408576698