Issue 653603002: Try to fix cross-script global scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 653603002: Try to fix cross-script global scope (Closed)

Created:
6 years, 2 months ago by rossberg

Modified:
6 years, 1 month ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Try to fix cross-script global scope Baseline is r22323 BUG=

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+269 lines, -74 lines)			Patch
M	src/compilation-cache.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/contexts.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/generator.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/globals.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/mirror-debugger.js	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	src/parser.cc	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	1	14 chunks	+84 lines, -18 lines	0 comments	Download
M	src/scopeinfo.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/scopes.h	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download
M	src/scopes.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	src/v8natives.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-decls.cc	View		2 chunks	+118 lines, -13 lines	0 comments	Download
M	test/message/single-function-literal.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/debug-function-scopes.js	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	test/mjsunit/harmony/debug-function-scopes.js	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	test/mjsunit/runtime-gen/compilestring.js	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/generate-runtime-tests.py	View		3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dmitry Lomov (no reviews)

6 years, 1 month ago (2014-11-07 16:56:29 UTC) #2

Message was sent while issue was closed.

On 2014/10/13 11:46:38, rossberg wrote:
> mailto:rossberg@chromium.org changed reviewers:
> + mailto:dslomov@chromium.org

Superceded by https://codereview.chromium.org/705663004/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages