Issue 653593003: replace newly added OVERRIDE in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 653593003: replace newly added OVERRIDE in content/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore

Modified:
6 years, 2 months ago

Reviewers:
falken, jochen (gone - plz use gerrit)

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

replace newly added OVERRIDE in content/ R=jochen@chromium.org,falken@chromium.org BUG=417463 Committed: https://crrev.com/b162ec76520509a254b13360e908c312758dd264 Cr-Commit-Position: refs/heads/master@{#299418}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/service_worker/service_worker_dispatcher_host_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mostyn Bramley-Moore

@jochen: PTAL at this trivial fixup to https://codereview.chromium.org/625533002

6 years, 2 months ago (2014-10-13 09:18:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653593003/1

6 years, 2 months ago (2014-10-14 00:38:01 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-14 01:40:07 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b162ec76520509a254b13360e908c312758dd264
Cr-Commit-Position: refs/heads/master@{#299418}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages