Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Issue 653593003: replace newly added OVERRIDE in content/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace newly added OVERRIDE in content/ R=jochen@chromium.org,falken@chromium.org BUG=417463 Committed: https://crrev.com/b162ec76520509a254b13360e908c312758dd264 Cr-Commit-Position: refs/heads/master@{#299418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Mostyn Bramley-Moore
@jochen: PTAL at this trivial fixup to https://codereview.chromium.org/625533002
6 years, 2 months ago (2014-10-13 09:18:11 UTC) #1
falken
lgtm
6 years, 2 months ago (2014-10-14 00:35:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653593003/1
6 years, 2 months ago (2014-10-14 00:38:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 01:39:02 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 01:40:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b162ec76520509a254b13360e908c312758dd264
Cr-Commit-Position: refs/heads/master@{#299418}

Powered by Google App Engine
This is Rietveld 408576698