Issue 653593002: Catch exceptions thrown when enqueuing change records.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 653593002: Catch exceptions thrown when enqueuing change records. (Closed)

Created:
6 years, 2 months ago by Yang

Modified:
6 years, 2 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Catch exceptions thrown when enqueuing change records. R=ishell@chromium.org BUG=chromium:417709 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24608

Patch Set 2 : addressed comment #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -66 lines)			Patch
M	src/accessors.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/accessors.cc	View	1	5 chunks	+14 lines, -9 lines	0 comments	Download
M	src/bootstrapper.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download
M	src/objects.cc	View	1	15 chunks	+75 lines, -36 lines	0 comments	Download
M	src/runtime/runtime-function.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime/runtime-object.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
A +	test/mjsunit/regress/regress-417709a.js	View		1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with nits: https://codereview.chromium.org/653593002/diff/1/src/accessors.cc File src/accessors.cc (right): https://codereview.chromium.org/653593002/diff/1/src/accessors.cc#newcode887 src/accessors.cc:887: static MaybeHandle<Object> SetFunctionPrototype(Isolate* isolate, MUST_USE_RESULT? https://codereview.chromium.org/653593002/diff/1/src/objects.h ...

6 years, 2 months ago (2014-10-13 10:47:25 UTC) #2

Yang

6 years, 2 months ago (2014-10-14 14:46:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:140001) manually as 24608 (presubmit successful).

Expand Messages | Collapse Messages

Issue 653593002: Catch exceptions thrown when enqueuing change records. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comment #

Messages